Commit 1b45bb6
committed
Fix memory leak in per-level FakePlayer cache
The FakePlayer value holds a strong reference to its ServerLevel key
(Entity.level), so a WeakHashMap (weak keys only) kept the key reachable
and leaked the level. Use a Guava MapMaker with weak keys AND values.1 parent c705909 commit 1b45bb6
1 file changed
Lines changed: 5 additions & 2 deletions
File tree
- loader-neoforge/src/main/java/org/cyclops/structuredcrafting/craft/provider
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | | - | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| |||
0 commit comments