Revert "Detector: Uninitialized local variables" (#658)

Author: alexroan

aderyn_core/src/context/meta_workspace.rs

@@ -188,10 +188,6 @@ impl WorkspaceContext {
         self.yul_identifiers_context.keys().collect()
     }
 
-    pub fn yul_assignments(&self) -> Vec<&YulAssignment> {
-        self.yul_assignments_context.keys().collect()
-    }
-
     pub fn yul_literals(&self) -> Vec<&YulLiteral> {
         self.yul_literals_context.keys().collect()
     }

aderyn_core/src/context/workspace_context.rs

@@ -94,7 +94,6 @@ pub struct WorkspaceContext {
     pub(crate) yul_function_calls_context: HashMap<YulFunctionCall, NodeContext>,
     pub(crate) yul_identifiers_context: HashMap<YulIdentifier, NodeContext>,
     pub(crate) yul_literals_context: HashMap<YulLiteral, NodeContext>,
-    pub(crate) yul_assignments_context: HashMap<YulAssignment, NodeContext>,
 }
 
 impl WorkspaceContext {

aderyn_core/src/detect/detector.rs

@@ -80,7 +80,6 @@ pub fn get_all_issue_detectors() -> Vec<Box<dyn IssueDetector>> {
         Box::<TxOriginUsedForAuthDetector>::default(),
         Box::<MsgValueUsedInLoopDetector>::default(),
         Box::<ContractLocksEtherDetector>::default(),
-        Box::<UninitializedLocalVariableDetector>::default(),
         Box::<ReturnBombDetector>::default(),
     ]
 }
@@ -158,7 +157,6 @@ pub(crate) enum IssueDetectorNamePool {
     TxOriginUsedForAuth,
     MsgValueInLoop,
     ContractLocksEther,
-    UninitializedLocalVariable,
     ReturnBomb,
     // NOTE: `Undecided` will be the default name (for new bots).
     // If it's accepted, a new variant will be added to this enum before normalizing it in aderyn
@@ -169,9 +167,6 @@ pub fn request_issue_detector_by_name(detector_name: &str) -> Option<Box<dyn Iss
     // Expects a valid detector_name
     let detector_name = IssueDetectorNamePool::from_str(detector_name).ok()?;
     match detector_name {
-        IssueDetectorNamePool::UninitializedLocalVariable => {
-            Some(Box::<UninitializedLocalVariableDetector>::default())
-        }
         IssueDetectorNamePool::ReturnBomb => Some(Box::<ReturnBombDetector>::default()),
         IssueDetectorNamePool::UnusedStateVariable => {
             Some(Box::<UnusedStateVariablesDetector>::default())

aderyn_core/src/detect/low/mod.rs

@@ -18,7 +18,6 @@ pub(crate) mod return_bomb;
 pub(crate) mod reverts_and_requries_in_loops;
 pub(crate) mod solmate_safe_transfer_lib;
 pub(crate) mod unindexed_events;
-pub(crate) mod uninitialized_local_variables;
 pub(crate) mod unsafe_erc20_functions;
 pub(crate) mod unsafe_oz_erc721_mint;
 pub(crate) mod unspecific_solidity_pragma;
@@ -49,7 +48,6 @@ pub use return_bomb::ReturnBombDetector;
 pub use reverts_and_requries_in_loops::RevertsAndRequiresInLoopsDetector;
 pub use solmate_safe_transfer_lib::SolmateSafeTransferLibDetector;
 pub use unindexed_events::UnindexedEventsDetector;
-pub use uninitialized_local_variables::UninitializedLocalVariableDetector;
 pub use unsafe_erc20_functions::UnsafeERC20FunctionsDetector;
 pub use unsafe_oz_erc721_mint::UnsafeERC721MintDetector;
 pub use unspecific_solidity_pragma::UnspecificSolidityPragmaDetector;

aderyn_core/src/detect/low/uninitialized_local_variables.rs

@@ -103,19 +103,6 @@ impl ASTConstVisitor for WorkspaceContext {
         Ok(true)
     }
 
-    fn visit_yul_assignment(&mut self, node: &YulAssignment) -> Result<bool> {
-        self.yul_assignments_context.insert(
-            node.clone(),
-            NodeContext {
-                source_unit_id: self.last_source_unit_id,
-                contract_definition_id: self.last_contract_definition_id,
-                function_definition_id: self.last_function_definition_id,
-                modifier_definition_id: self.last_modifier_definition_id,
-            },
-        );
-        Ok(true)
-    }
-
     // Read the following like follows -
     generate_visit_methods_for_workspace_context_with_insert_node! {
         // Explanation for the 1st one : Create a method called `visit_assignment` that takes in `Assignment` as parameter and puts it inside `assignments_context`