Please give us feedback and improvement points!

[PatrickAlphaC]

In this thread, please leave feedback on your favorite parts, and least favorite parts of the course!

This way, we can keep updating so we can make Cyfrin Updraft easier and easier for you to learn.

CURRENT FEEDBACK POINTS:

• Quizzes
• More challenges

[KeySkills]

In Advanced Foundry Course, Section 3 - Develop Defi Protocol Lesson 16: DSCEngine advanced testing and Lesson 17: Write fuzz tests and contain the same video.

[EngrPips]

There is something in the pipe for front end I believe

[KillerwhaleFx]

I love it here

[EngrPips]

I love it here

We love to have you.

[0xAnalystt]

i just finished blockchain overview, L1s, L2s and rollups, my gosh it was really worth it. taking a break now tho.

[EngrPips]

i just finished blockchain overview, L1s, L2s and rollups, my gosh it was really worth it. taking a break now tho.

I am glad you enjoyed it.

[Aaryan-Urunkar]

First of all, a supreme effort and a mega thanks to the Cyrfin team and @PatrickAlphaC sir for creating this course! I just had a few pieces of feedback:

1. The ERC-20 token and the NFT part seemed a bit rushed, which I don't know why put me off from finishing video 2(or even touching the course) for nearly a week. I don't know if it was just me or anybody else as well, but yeah, thought of putting it down here.

2. Secondly, I had migrated to this course after watching nearly 8 hours of the Hardhat one from freecodecamp which is outdated and hence I found it difficult to follow that one. It would be VERY VERY appreciated if the team could do a similar frontend course. Even if it isn't an entire mammoth course with the new updated Hardhat but just the frontend part for some of the existing foundry projects from this course, I would appreciate it, and I think many others would too!

Thankyou again!!!

[PatrickAlphaC]

ERC-20 token and the NFT part seemed a bit rushed

Thanks for this feedback! Which parts would you have wished we went over deeper / slower so it would feel less rushed?

a similar frontend course.

This year ;)

[Aaryan-Urunkar]

The parts I feel you should have dived deeper into is definitely during the ERC20 intro section. I left that section feeling doubtful if I understood it or not but yeah, during DSC, I had to google a lot of stuff abt ERC-20 which I previously was unclear about. Hence I feel that the ERC-20 section can slightly be improved so that by DSC everyone has a better idea abt what ERC-20s are.

Very hyped up for the frontend course sir!! Already know it's gonna be a bombshell as soon as it is out! In the meanwhile, just gonna build up project from whatever I have learned so far.

EDIT: Thanks to this course I ended up with my first ever answer on stack overflow lol! (https://stackoverflow.com/a/78801142)

[bibhashdash]

Thanks for the course it's really good. I was wondering, is there a way to flag (or bookmark) a specific video so that we can easily come back to it later? I know we can leave it 'unchecked' but perhaps a quicker way would be to maybe filter and find all the bookmarked ones.
Anyway, just a thought. Great work on the course and looking forward to continuing my journey in web3.

[PatrickAlphaC]

Oooo interesting. Good feature request!

[SiewLin-AIDeaBuddy]

Thanks a lot for the excellent educative course materials. The option to learn sectioned videos in Updraft instead of a combined long hours video is greatly appreciated. Would like to give generic improvement feedbacks as below:

1. To include feature where user can easily take notes at any timestamp of the course tutorial videos in order to further deep dive on certain topics at later stage or to jot down topics that need attention. User can also easily view/search those notes made at various timestamps to revise the topics again instead of searching and rewatching the entire video to find the one that is relevant to revise.

2. It would be very helpful if after each new topic, a relevant past audit case study with solution or actual hacked protocols walk through is included at the end / or at the right time junction within the course to further enhance the understanding and applicability of the topic in real case.

3. Similar to 2 above, at the end of several topics/chapters/modules, if there is a relevant section in first flight / audits that closer to the taught topics, the inclusion of those info can be added apart from any planned challenges/quizzes. This is especially useful for those who just started in the field to get closer to something that they can attempt to after the lesson to test out their understanding of the topic rather than hunting around the various sources to find out that the real test/audit is far beyond from what they have learned at that point, and couldn’t really apply due to lots of missing pieces of associated knowledge. Perhaps can utilize / modify past first flight/audit to cater the learning needs/tests for targeted topics, this makes the learning more effective as it is closer to actual applications.

[EngrPips]

Interesting feedback.

[Equious]

@Eversmile12 Some food for thought.

[mpuj99]

Thanks for this course Patrick, it was amazing. Really well explained.
Two things I noticed during these course:

1. In section 3 - Develop DEFI protocol, in Lesson 20: Create the collateral redeem handler, when you create the line to get the collateral of a user:

uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(sender, address(collateral));

The function it has this order of arguments:

function getCollateralDepositedOfUser(address user, address token) external view returns(uint256)

First is the address of the user and then the address of the token, in the video you put first the token and then the user:

uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(address(collateral), sender);

I suppose it doens't fail because both are addresses, I looked at the logs and when we console maxAmountCollateralToRedeem is equal to zero. So never fails, if you put it good the arguments it fails with the assertion failed:
(totalWethValue + totalWbtcValue) >= totalSupply in InvariantTest.t.sol
I tried to fix it but it was hard, because I think the problem was that we were depositing collateral, minting and redeeming but in that lesson we weren't burning so, I fixed only for 5 invariant executions, creating redeeming and burning in the same function, on the 6th execution found some value that cracked the healthFactor, so I gave up because I spent too much time on creating the function to redeem and burn at the same time. So just telling you, maybe you can fix it in a new video with the arguments good positioned.
But overall, just want to say that the DEFI protocol section was my favourite section of Advanced Foundry, I learned a lot.

2. Is a silly thing but, in the last section: Security, in the lesson 3: Top security tools, from the minute 9:23 till 9:34 is all black, is nothing but just saying maybe you didn't notice it.
   Thank you very much, amazing course. With eager to start hitting the security and auditing course!!!!

Regards,

[EngrPips]

Awesome Feedback, I trust he will reply to this as soon as he is available.

[PatrickAlphaC]

So sorry I missed this! Thanks for the feedback here :) We will fix!

[thxpikachu]

In Blockchain Basics, Section 6 - The Purpose of Smart Contracts, the video cuts off a bit too early. The sentence was supposed to end with "and wash out the products that aren't actually contributing to Web3,"
but on Cyfrin Updraft, it abruptly stops at "aren't actually contribut-".

It's not a big deal, but my perfectionist brain can't bear it. :)

[EngrPips]

Thanks for the feedback, This will be attended to appropriately as soon as possible.

[Equious]

FYI @PatrickAlphaC 🙏

[MattSWeb3]

In "Blockchain Basics 11. Quiz: Blockchain Basics Mid Section Recap" Question 4 "What is the role of the gas price in ETH?" refers to the next video of the course "12. Introduction to Gas". Shouldn't the videos be the other way around? Since the quiz asks about something we didn't see up to that point.

[EngrPips]

Thanks for the feedback, This will be attended to appropriately as soon as possible.

[Dennnnny]

hey, I have a little question about quiz below:
In Foundry Fundamentals Section4 Smart Contract Lottery 11. Quiz: Smart Contract Lottery Intro
number 4 about How can you use the modulo operator (%) to determine if a number is even or odd?

I think If n % 2 != 1, the number is even. Otherwise, it's odd. this option is also correct (?)
because if a number % 2, is either 0 or 1

[EngrPips]

I think you have a point, This will be looked into as soon as possible.

[felixoder]

The logic you mentioned is partially correct, but not always reliable due to how modulus works with negative numbers. Here's why:

1. For positive numbers, n % 2 != 1 would work, because positive odd numbers will have a remainder of 1 when divided by 2 {Two}.
2. However, for negative odd numbers, the result of n % 2 is not necessarily 1. For example, -3 % 2 gives -1, not 1. So the check n % 2 != 1 would fail for negative odd numbers.

The safer way is to simply check n % 2 == 0 for even numbers (both positive and negative), and if not, the number is odd.

[MattSWeb3]

In Blockchain Basics course the written lesson on 16. Blockchain Overview has a small mistake in:
"A chain selection rule is implemented as a means to determine which blockchain is the real blockchain. Bitcoin (and prior to the merge, Ethereum), both use something called **Nakomoto** Consensus. This is a combination of Proof of Work (Etherum has since switched to Proof of Stake) and the longest chain rule."
It should be written "Nakamoto".

Thanks for the amazing work you guys have been doing. I'm loving the course!!

[EngrPips]

Thanks for pointing this out and this will be attended to as soon as possible.

[Equious]

This has been updated! In future you can definitely submit PRs for the written lessons to the dev branch on this repo: https://github.com/Cyfrin/Updraft

[khandelwalmoksh]

In "New discussion" section, "Preview" isn't working properly
my code:

       assertEq(fundMe.i_owner(), address(this));
   }```

my code ``` function testOwnerIsMsgSender() public {
       assertEq(fundMe.i_owner(), address(this));
} ```
   
![Screenshot (18)](https://github.com/user-attachments/assets/5c871d3f-68f9-46e0-9367-30255c426a95)
![Screenshot (19)](https://github.com/user-attachments/assets/1e3140e4-5800-46ff-b9d3-7043b5add0ec)


U can clearly see the difference, the 1st code is incomplete whereas, 2nd is complete

[khandelwalmoksh]

these must help you
U can clearly see the difference, the 1st code is incomplete whereas, 2nd is complete

[EngrPips]

I see, It will be looked into. thanks for the contribution.

[PatrickAlphaC]

Place the ``` on their own line, like this:

```
hi!
```

[chandalalaguidance-beep]

What kind of software among the Microsoft office package can you use to make your EIPS and CRC token
Where can I find the lesson about web designing

[EngrPips]

What kind of software among the Microsoft office package can you use to make your EIPS and CRC token Where can I find the lesson about web designing

If you search the web, you will find a lesson about web design.

[khandelwalmoksh]

"IF YOU CAN" provide Patrick's codes used in Foundry Fundamentals, it would be very beneficial. Using the Solidity codes and the ones given in the repo, are giving countless errors. Even Phind ai can't help. And @EngrPips & others has to go through every line of the code provided to figure out what's wrong. This process eats up 2-3 days, thereby wasting the precious time of both, the questioner and solver. Thank you

[EngrPips]

Hello @khandelwalmoksh, I think you should not bother about the final code of each course but instead code along with Patrick, and like that, you won't run into too many problems, what do you think?

[PatrickAlphaC]

We do provide the code for each! Are you unable to find it?

[chainflash]

lesson 6 part 3 to 7 is a bit difficult for windows users

[EngrPips]

Thanks for pointing this out and this will be attended to as soon as possible.

[dvinubius]

Wrong answer for question 1 in the Quiz Fund Me Section Recap

Choice 3 is not entirely accurate. Constants cannot be assigned at any point, but must be assigned with an explicit value in the source code, so that the value is known at compile time. They are being specified at compile time and effectively set in storage on deployment.

Choice 4 is arguably correct though. Immutables can be set with one value when declared, and then updated when the constructor runs. Constants, on the other hand, can't ever be updated (which implies they were having another value before). They can only be specified once, at compile time, and then set accordingly when initialized, namely on deployment.

[EngrPips]

Thanks for pointing this out and this will be attended to as soon as possible.

[Equious]

Updated this question with some hopefully more clear/appropriate answers. Thanks for the feedback

[uddercover]

I noticed a blank part of the video in lesson 4, advanced foundry security section.
Timestamp: 9:22 - 9:34

[EngrPips]

Thanks for this feedback. This will be looked into.

[Equious]

This seems to be fixed. Thanks for the report.

[engAbody]

i had been in many other courses looking for problem to practice ,
i found that even chainlink make training question in code format at Githup

not hard and does not require special website

Thanks for consideration ,,

[abdulsamed1]

When will the Arabic subtitle 🇸🇦 be added?

[EngrPips]

Interesting. @Equious

[WhiteKnightK]

In the 25th lesson of the DeployRaffle course, the text portion and the video portion seem to have different content. I am not sure if it is the text course of other video content.

[EngrPips]

Awesome, This will be looked into as soon as possible. @PatrickAlphaC @Equious sir

[CodeAtomsphere]

A feedback? My Mac just went faulty, I need a new one 🤦‍♂️

[EngrPips]

Make sure to buy minimum of 16gb ram and 512 SSD for good workflow.

[CodeAtomsphere]

Ikr, just broke 😂

[Ilikeatingvegtable123]

You could add questions in the written lessons at the end of the lesson for some courses (e.g, Foundry Fundamentals or Advanced Foundry). Some other courses have lessons that add questions at the end of it that help ingrain knowledge.

[EngrPips]

Thanks for the contribution. @PatrickAlphaC @Equious sir

[WhiteKnightK]

In the Advanced Foundry course, specifically in the '4. Introduction to IPFS' lesson, it seems that there are no subtitles available in Chinese. As I am not a native English speaker, I am having difficulty fully understanding the content of this video. Could you please consider adding Chinese subtitles?

[EngrPips]

Thanks for raising this concern. @PatrickAlphaC @Equious sir

[Equious]

Thanks, I'll have a look at generating this on Monday.

[wildjos]

Comment on Blockchain Basics
Section 22: Quiz: Blockchain Basics Recap
A question on "What is a Rollup Stage" has not been covered. The answer is in the next section, 23: Rollup Stages.

Image to illustrate:

[EngrPips]

@Equious sir

[DegenMouse]

I have just finished the Blockchain Fundamentals Course and it was truly a pleasure, and i felt like I really dipped my feet in blockchain. The videos were great and whenever the "give feedback page" appeared after the end of some videos I have always clicked the like button. But I think a small quality of life improvement would be really useful.

Right now when i click the "like" button you get this pop up only once:

But someone (i think it even happened to me) can accidentally click the wrong button, and there is no feedback to whether what button was pressed. So i think a on click highlight would be appreciated.

Something like this:

[EngrPips]

Hello @SnavMaster09, Thanks for the feedback. @Equious sir

[leetebbs]

I am working on the Advanced Foundry , Develop an NFT Collection.
In section 15: Modify the NFT image onChain you use

function flipMood(uint256 tokenId) public {
    if (!_isApprovedOrOwner(msg.sender, tokenId)) {
        revert MoodNft__NotOwnerNorApproved();
    }
    if (s_tokenIdToMood[tokenId] == Mood.HAPPY) {
        s_tokenIdToMood[tokenId] = Mood.SAD;
    } else {
        s_tokenIdToMood[tokenId] = Mood.HAPPY;
    }
}

but i cannot find _isApprovedOrOwner in the ERC721 Contract.

I have set mine to

function flipMood(uint256 tokenId) public {
        if (ownerOf(tokenId) != msg.sender) {
            revert MoodNft__NotOwnerNorApproved();
        }
        if (s_tokenIdToMood[tokenId] == Mood.HAPPY) {
            s_tokenIdToMood[tokenId] = Mood.SAD;
        } else {
            s_tokenIdToMood[tokenId] = Mood.HAPPY;
        }
    }

Is this me or have things changed in the ERC721 openzepplin contract?

Great course by the way
Thanks

[EngrPips]

Things changed, and these changes are always addressed in the chronological-update section https://github.com/Cyfrin/foundry-full-course-cu/blob/main/chronological-updates.md of the GitHub repo associated with the course.

[Damsel05]

Hi, Can I use my phone to do all these cos my laptop is bad at the moment.

[EngrPips]

You can sure try with your phone but a laptop will make things easier.

[Kelechikizito]

Hey @PatrickAlphaC, I appreciate you and your team (Cyfrin). The Aragon DAO tutorial is currently outdated, so I thought I would bring it to your notice.

[EngrPips]

Hey @PatrickAlphaC, I appreciate you and your team (Cyfrin). The Aragon DAO tutorial is currently outdated, so I thought I would bring it to your notice.

Thanks for pointing this out @Kelechikizito. @PatrickAlphaC @Equious

[ciaranightingale]

Hi @Kelechikizito thanks for flagging this - we are rectifying 👍 appreciate it ser

[mirmohmmadluqman]

Hi @PatrickAlphaC ! You have different written lessons and video lessons in Foundry Fundamentals, Raffle Lottery. In videos, you have a function namely pickwinner() but in written lessons there is performupkeep()..., and also in repo of it, there is whole Raffle Lottery with performupkeep()... function and you are teaching pickwinner() in videos.

[mirmohmmadluqman]

I had gave feedback to updraft, you have fixed in written lessons, but not repo yet

[EngrPips]

@mirmohmmadluqman Have you completed the video lesson for the Raffle section?

[mirmohmmadluqman]

@EngrPips Do you mean all videos !

[mirmohmmadluqman]

@EngrPips I know the name of function will be changed but I am telling that:

In videos, you have a function namely pickwinner() but in written lessons there is performupkeep()...

They have fixed it now !

[EngrPips]

@EngrPips I know the name of function will be changed but I am telling that:

In videos, you have a function namely pickwinner() but in written lessons there is performupkeep()...

They have fixed it now !

Oh, Interesting. I am glad that has been fixed.

[mirmohmmadluqman]

I tried to do exam for it, and it showed me:

Oh no! Unfortunately, your score did not meet the minimum, and you did not pass the exam. The good news is that you can retake it in two days.
Retake exam in *** * ** * *

---

and when I tried to give you feedback thrice even after reloading, it always showed 'Invalid Feedback' !

[EngrPips]

Please join the official Discord server of Cyfrin https://discord.gg/tZP4dE6C and report this issue using a support ticket

[mirmohmmadluqman]

It automatically answers the question without even touching any button

[EngrPips]

@PatrickAlphaC @Equious

[EngrPips]

@mirmohmmadluqman, you may also use Cyfrin's official Discord to report this. Open a support ticket on there and report.

[Equious]

Thanks, we'll have a look.

[1khushibarnwal]

Thank you so much @PatrickAlphaC for making such a wonderful course.
I struggled a lot in the FundMe contract when you were explaining the Chainlink part, but I understand that's just a part of it. I would really appreciate if you could come up with more courses about BLOCKCHAIN ORACLES.

Once again, thanks for this.

Love from India.

[EngrPips]

Great Feedback.