I built a Voting System

[MartinsAloysius]

Hey guys, checkout this github repo to see the voting system I built. Do let me know what you think. Here is the link: https://github.com/MartinsAloysius/VotingSystem

Also, I'll be looking forward to meeting anyone who would love to join me in my next project. Dm me via telegram: @XTER_THY or via X: https://x.com/Xterthy_3

[EngrPips]

Great job @MartinsAloysius

[MartinsAloysius]

Thanks man

Hey man, would you be willing to join a dev community where they help you do your job hunting, share tips, bounties, hackathons, news and resources for developers.

It's a recruitment community

[EngrPips]

That seems interesting, share the community with me.

[MartinsAloysius]

Here's the channel link: https://t.me/web3devs3
Here's the chat link: https://t.me/web3devsweb3

[EngrPips]

Here's the channel link: https://t.me/web3devs3 Here's the chat link: https://t.me/web3devsweb3

Thanks, Friend.

[sivity123]

Nice and clean work 👏 @MartinsAloysius :)

[MartinsAloysius]

Thanks man

[mirmohmmadluqman]

Hey @MartinsAloysius, dude, I just stumbled across your VotingSystem repo, and holy cow, I’m absolutely blown away! Seriously, you’ve built something that’s not just a cool learning project but a legit stepping stone into the wild world of Solidity—props to you for dropping that on GitHub! The way you’ve nailed down structs, mappings, modifiers, and events in such a clean setup with owner controls and that slick one-vote-per-address rule? Mind-blowing for a portfolio piece, man!

But hold onto your seat, because I’ve got some next-level upgrades to throw your way that’ll make your jaw drop and turn this into a beast of a contract. I’ve been digging into the Cyfrin Foundry course (that monster Patrick Collins put together) and flipping through "Mastering Ethereum" by Andreas Antonopoulos and Gavin Wood—yep, the bee-covered bible of smart contracts! Here’s what I think you should blast into this project to shock the web3 world:

1. OpenZeppelin Power-Up: Ditch that custom onlyOwner and grab OpenZeppelin’s Ownable—it’s like the superhero cape of ownership management, battle-tested and ready to handle transfers like a pro. Just toss in import "@openzeppelin/contracts/access/Ownable.sol"; and make it is Ownable. Trust me, it’s a game-changer!

2. Vote Peek Feature: Right now, folks are digging into mappings manually—let’s make it easier! Add a getCandidateVotes(uint256 _id) public view returns (uint256) function so anyone can check vote counts without breaking a sweat off-chain.

3. Edge Case Explosion: What if someone tries to sneak in a candidate mid-vote? Add a beforeVoting() modifier to lock addCandidate before voting kicks off. Oh, and maybe throw in a reset for hasVoted or a new round system—imagine the reusability!

4. Security Wizardry: Run Slither with slither . to catch any sneaky bugs (no reentrancy here, but still!). For Foundry, crank up the fuzz testing with invariants—how about asserting totalVotes always matches the sum of all candidate votes? You’ll be a security rockstar!

5. Gas Ninja Moves: You’re already using ++ like a champ with candidateCount, but if you scale this up, pack those structs to save storage slots. Efficiency is king!

Check this out—I’ve refactored your contract with these mind-blowing tweaks. Test it like crazy, but here it is:

// SPDX-License-Identifier: License @MartinsAloysius will put in his repo `https://github.com/MartinsAloysius/VotingSystem`
pragma solidity ^0.8.20;

import "@openzeppelin/contracts/access/Ownable.sol";

contract VotingSystem is Ownable {
    bool public votingActive;

    struct Candidate {
        uint256 id;
        string name;
        uint256 voteCount;
    }

    mapping(uint256 => Candidate) public candidates;
    mapping(address => bool) public hasVoted;

    uint256 public candidateCount;
    uint256 public totalVotes;

    event CandidateAdded(uint256 id, string name);
    event VoteCast(address voter, uint256 candidateId);
    event VotingStarted();
    event VotingEnded();

    modifier votingIsActive() {
        require(votingActive, "Voting not active");
        _;
    }

    modifier beforeVoting() {
        require(!votingActive, "Voting already started");
        _;
    }

    function addCandidate(string memory _name) public onlyOwner beforeVoting {
        candidateCount++;
        candidates[candidateCount] = Candidate(candidateCount, _name, 0);
        emit CandidateAdded(candidateCount, _name);
    }

    function startVoting() public onlyOwner {
        require(candidateCount > 0, "Add candidates first");
        votingActive = true;
        emit VotingStarted();
    }

    function endVoting() public onlyOwner {
        votingActive = false;
        emit VotingEnded();
    }

    function vote(uint256 _candidateId) public votingIsActive {
        require(!hasVoted[msg.sender], "Already voted");
        require(_candidateId > 0 && _candidateId <= candidateCount, "Invalid candidate");

        hasVoted[msg.sender] = true;
        candidates[_candidateId].voteCount++;
        totalVotes++;
        emit VoteCast(msg.sender, _candidateId);
    }

    function getCandidateVotes(uint256 _id) public view returns (uint256) {
        require(_id > 0 && _id <= candidateCount, "Invalid candidate");
        return candidates[_id].voteCount;
    }
}

This is next-level stuff, bro! Deploy it on Sepolia with Foundry and drop the address—let’s see it in action and get some live feedback. And hey, I’m pumped for your next project—hit me up on or X(@mirmohmmadluqman) if you’re down to collab on something insane, like mashing this with Solana for cross-chain voting (that ETS thesis from Federico Pomponii’s got some wild token ideas!). Keep crushing it, man. I have also a project but I am learning the skills to work for that, can you tell me your skills man, but skills related to web3. You’re about to blow the web3 community away! 🚀

[mirmohmmadluqman]

Hey @MartinsAloysius !

Have discussion in Your repo, so if anybody found error, bug, improvement(for-it) or anything, they can post it there...

[mirmohmmadluqman]

@MartinsAloysius here's a pro tip, have a LICENSE for you project/repo !