Skip to content

Commit 7e74f5e

Browse files
fix: Display output count in verification
Signed-off-by: Prashant Rahul <prashantrahul141@protonmail.com>
1 parent 3d26df5 commit 7e74f5e

1 file changed

Lines changed: 17 additions & 13 deletions

File tree

apps/cardano_app/cardano_txn.c

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,8 @@ static bool get_user_verification() {
556556
char to_address[CARDANO_PAYMENT_ADDR_LENGTH + 1] = {0};
557557
memzero(to_address, sizeof(to_address));
558558

559+
char display[100] = {'\0'};
560+
559561
for (size_t output_i = 0;
560562
output_i < cardano_txn_context->parsed_txn.outputs_count;
561563
output_i++) {
@@ -570,8 +572,10 @@ static bool get_user_verification() {
570572
}
571573
}
572574

573-
if (!core_scroll_page(
574-
ui_text_verify_address, to_address, cardano_send_error)) {
575+
char title[30] = {0};
576+
(void)snprintf(
577+
title, sizeof(title), "%s #%d", ui_text_verify_address, output_i + 1);
578+
if (!core_scroll_page(title, to_address, cardano_send_error)) {
575579
return false;
576580
}
577581

@@ -580,27 +584,27 @@ static bool get_user_verification() {
580584
cardano_txn_context->parsed_txn.outputs[output_i].receive_amount);
581585
(void)snprintf(amount_string, sizeof(amount_string), "%.6f", amount_ada);
582586

583-
char display[100] = {'\0'};
584587
(void)snprintf(display,
585588
sizeof(display),
586-
UI_TEXT_VERIFY_AMOUNT,
589+
"Verify amount #%d\n%s\n%s",
590+
output_i + 1,
587591
amount_string,
588592
CARDANO_LUNIT);
589593

590594
if (!core_confirmation(display, cardano_send_error)) {
591595
return false;
592596
}
597+
}
593598

594-
/* verify fees */
595-
char fees_string[30] = {0};
596-
double fees_ada = ada_from_lovelace(cardano_txn_context->parsed_txn.fees);
597-
memzero(display, sizeof(display));
598-
(void)snprintf(fees_string, sizeof(fees_string), "%.6f", fees_ada);
599-
(void)snprintf(display, sizeof(display), "Verify fees\n%s", fees_string);
599+
/* verify fees */
600+
char fees_string[30] = {0};
601+
double fees_ada = ada_from_lovelace(cardano_txn_context->parsed_txn.fees);
602+
memzero(display, sizeof(display));
603+
(void)snprintf(fees_string, sizeof(fees_string), "%.6f", fees_ada);
604+
(void)snprintf(display, sizeof(display), "Verify fees\n%s", fees_string);
600605

601-
if (!core_confirmation(display, cardano_send_error)) {
602-
return false;
603-
}
606+
if (!core_confirmation(display, cardano_send_error)) {
607+
return false;
604608
}
605609

606610
set_app_flow_status(CARDANO_SIGN_TXN_STATUS_VERIFY);

0 commit comments

Comments
 (0)