fix phpstan errors

Author: FlexBy420

public_html/lib/module/rpcn/games.json

@@ -1289,7 +1289,7 @@
 },
 "NPWR00628_00": {
     "title": ["無双OROCHI Z"],
-    "id": ["BLJM60139"]
+    "id": ["BLJM60139", "BLAS50130"]
 },
 "NPWR00629_00": {
     "title": ["Age of Booty"],
@@ -4257,7 +4257,7 @@
 },
 "NPWR01730_00": {
     "title": ["inFAMOUS 2"],
-    "id": ["BCES01143", "BCES01144", "BCES01229", "BCJS30075", "BCUS98125", "NPEA00318"]
+    "id": ["BCES01143", "BCES01144", "BCES01229", "BCJS30075", "BCUS98125", "NPEA00318", "BCAS20181"]
 },
 "NPWR01731_00": {
     "title": ["Mercury Hg"],
@@ -6337,7 +6337,7 @@
 },
 "NPWR03466_00": {
     "title": ["アーシャのアトリエ　～黄昏の大地の錬金術士～"],
-    "id": ["BLES01793", "BLJM60486", "BLUS31152"]
+    "id": ["BLES01793", "BLJM60486", "BLUS31152", "BLAS50502"]
 },
 "NPWR03468_00": {
     "title": ["Far Cry 3"],
@@ -9025,7 +9025,7 @@
 },
 "NPWR06754_00": {
     "title": ["MOBILE SUIT GUNDAM SIDE STORIES"],
-    "id": []
+    "id": ["BLAS50710"]
 },
 "NPWR06757_00": {
     "title": ["Disney Infinity [2.0]"],
@@ -9341,7 +9341,7 @@
 },
 "NPWR07534_00": {
     "title": ["The Evil Within"],
-    "id": []
+    "id": ["BCAS20333"]
 },
 "NPWR07535_00": {
     "title": ["The Evil Within"],

public_html/lib/module/rpcn/inc-rpcn-stats.php

@@ -3,11 +3,18 @@ class RPCNStats {
     private string $games_json;
     private string $log_file;
     private string $api_url;
-    public array $title_regions = [];
 
     public int $total_users = 0;
+
+    /** @var array<string, array<int, string>> */
+    public array $title_regions = [];
+
     /** @var array<string, int> */
     public array $title_player_counts = [];
+
+    /** @var array<string, array<string>> */
+    public array $title_ids = [];
+
     public bool $has_error = false;
 
     public function __construct(string $games_json, string $log_file, string $api_url) {
@@ -59,6 +66,9 @@ private function processStats(): void {
         }
 
         $json_content = file_get_contents($this->games_json);
+        if ($json_content === false) {
+            throw new Exception("Unable to read {$this->games_json}");
+        }
         $game_mappings = json_decode($json_content, true);
 
         if (json_last_error() !== JSON_ERROR_NONE) {
@@ -67,15 +77,14 @@ private function processStats(): void {
 
         // cURL
         $ch = curl_init();
+        assert($this->api_url !== '');
         curl_setopt($ch, CURLOPT_URL, $this->api_url);
         curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
         curl_setopt($ch, CURLOPT_HEADER, true);
         curl_setopt($ch, CURLOPT_HTTPHEADER, [
             'Accept: application/json',
         ]);
 
-        $response = curl_exec($ch);
-
         if (curl_errno($ch)) {
             $error_message = 'cURL error: ' . curl_error($ch);
             $this->log_error($error_message);
@@ -90,18 +99,19 @@ private function processStats(): void {
             throw new Exception($error_message);
         }
 
-        $header_size = curl_getinfo($ch, CURLINFO_HEADER_SIZE);
-        $api_data = substr($response, $header_size);
-
-        curl_close($ch);
-
-        if ($api_data === false) {
-            $last_error = error_get_last();
-            $error_message = $last_error ? $last_error['message'] : 'Unknown error occurred while fetching API data';
+        $response = curl_exec($ch);
+        if ($response === false) {
+            $error_message = 'cURL error: ' . curl_error($ch);
             $this->log_error($error_message);
             throw new Exception($error_message);
         }
 
+        /** @var string $response */
+        $header_size = curl_getinfo($ch, CURLINFO_HEADER_SIZE);
+        $api_data    = substr($response, $header_size);
+
+        curl_close($ch);
+
         $data = json_decode($api_data, true);
         if (json_last_error() !== JSON_ERROR_NONE) {
             $error_message = json_last_error_msg();
@@ -114,7 +124,7 @@ private function processStats(): void {
         // Merge Player Counts from API Data
         foreach ($game_mappings as $comm_id => $info) {
             $titles = $info['title'] ?? ["Unknown Game"];
-            $game_title = $titles[0];
+            $game_title = $titles[0] ?? 'Unknown Game';
 
             // Initialize counts and ID array if not already set
             if (!isset($this->title_player_counts[$game_title])) {
@@ -131,18 +141,28 @@ private function processStats(): void {
 
             foreach ($ids as $entry_id) {
                 $region = $this->get_region_from_id($entry_id);
-                if (!in_array($region, $this->title_regions[$game_title])) {
+                if (!array_key_exists($game_title, $this->title_regions)) {
+                    $this->title_regions[$game_title] = [];
+                }
+                if (!in_array($region, $this->title_regions[$game_title], true)) {
                     $this->title_regions[$game_title][] = $region;
                 }
             }
 
-            sort($this->title_regions[$game_title], SORT_STRING);
+            if (!empty($this->title_regions[$game_title])) {
+                sort($this->title_regions[$game_title], SORT_STRING);
+            }
             $comm_id_player_count = 0;
 
             // First try psn_games (comm_id)
             if (isset($data['psn_games'][$comm_id])) {
                 $value = $data['psn_games'][$comm_id];
-                $comm_id_player_count += is_array($value) ? (int)$value[0] : (int)$value;
+            
+                if (is_array($value) && isset($value[0])) {
+                    $comm_id_player_count += (int) $value[0];
+                } elseif (is_int($value)) {
+                    $comm_id_player_count += $value;
+                }
             }
 
             // If we got a comm_id match, skip ticket_games