Skip to content

Commit 61a0ba5

Browse files
committed
#566: removed QOIs from test harness
1 parent 1c076dd commit 61a0ba5

File tree

4 files changed

+19
-21
lines changed

4 files changed

+19
-21
lines changed

tests/unit/Execution/test_lbs_brute_force_algorithm.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ def setUp(self):
6969
"max_objects_per_transfer": 8,
7070
"deterministic_transfer": True
7171
},
72-
lgr=self.logger,
73-
rank_qoi=None,
74-
object_qoi=None)
72+
lgr=self.logger)
7573

7674
self.brute_force = BruteForceAlgorithm(
7775
work_model=WorkModelBase(),
@@ -84,9 +82,7 @@ def setUp(self):
8482
"max_objects_per_transfer": 8,
8583
"deterministic_transfer": True
8684
},
87-
lgr=self.logger,
88-
rank_qoi=None,
89-
object_qoi=None)
85+
lgr=self.logger)
9086

9187
def test_lbs_brute_force_skip_transfer(self):
9288
assert self.brute_force_skip_transfer._BruteForceAlgorithm__skip_transfer is True

tests/unit/Execution/test_lbs_centralized_prefix_optimizer_algorithm.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,12 @@ def setUp(self):
6666
parameters={},
6767
lgr=self.logger)
6868
parameters = {"do_second_stage": True}
69-
qoi_name = "load"
7069

7170
# Create CPOA instance
7271
self.cpoa = CentralizedPrefixOptimizerAlgorithm(
73-
work_model=work_model,
74-
parameters=parameters,
75-
lgr=self.logger,
76-
qoi_name=qoi_name,
77-
obj_qoi=qoi_name
78-
)
72+
work_model=work_model,
73+
parameters=parameters,
74+
lgr=self.logger)
7975

8076
# Set up phase
8177
self.sentinel_objects = {Object(seq_id=15, load=4.5), Object(seq_id=18, load=2.5)}

tests/unit/Execution/test_lbs_inform_and_transfer_algorithm.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ def setUp(self):
7474
"max_objects_per_transfer": 8,
7575
"deterministic_transfer": True
7676
},
77-
lgr=self.logger,
78-
rank_qoi=None,
79-
object_qoi=None)
77+
lgr=self.logger)
8078

8179
@patch.object(random, "sample")
8280
def test_lbs_inform_and_transfer_forward_message(self, random_mock):
@@ -114,4 +112,4 @@ def test_lbs_inform_and_transfer_process_message(self):
114112
self.assertEqual(known_peers, {self.rank: {self.rank, temp_rank_1}})
115113

116114
if __name__ == "__main__":
117-
unittest.main()
115+
unittest.main()

tests/unit/Execution/test_lbs_runtime.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,17 +93,25 @@ def setUp(self):
9393
n_ranks = 4
9494
self.arrangements = compute_min_max_arrangements_work(objects, alpha, beta, gamma,
9595
n_ranks, logger=self.logger)[2]
96-
self.rank_qoi = None
97-
self.object_qoi = None
9896
# Initialize the Runtime instances
99-
self.runtime = Runtime(self.phases, self.work_model, self.algorithm, self.arrangements, self.logger, self.rank_qoi, self.object_qoi)
97+
self.runtime = Runtime(
98+
self.phases,
99+
self.work_model,
100+
self.algorithm,
101+
self.arrangements,
102+
self.logger)
100103

101104
def test_lbs_runtime_get_work_model(self):
102105
self.assertEqual(self.runtime.get_work_model().__class__, AffineCombinationWorkModel)
103106

104107
def test_lbs_runtime_no_phases(self):
105108
with self.assertRaises(SystemExit) as context:
106-
runtime = Runtime(None, self.work_model, self.algorithm, self.arrangements, self.logger, self.rank_qoi, self.object_qoi)
109+
runtime = Runtime(
110+
None,
111+
self.work_model,
112+
self.algorithm,
113+
self.arrangements,
114+
self.logger)
107115
self.assertEqual(context.exception.code, 1)
108116

109117
def test_lbs_runtime_execute(self):

0 commit comments

Comments
 (0)