Skip to content

Commit e5b2616

Browse files
committed
#594: modified CI to check for missing beta not alpha
1 parent 7a6175a commit e5b2616

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

config/challenging-toy-fewer-tasks.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ overwrite_validator: false
1010
work_model:
1111
name: AffineCombination
1212
parameters:
13-
alpha: 1.
14-
beta: 0.
15-
gamma: 0.
13+
beta: 0.0
14+
gamma: 0.0
1615
upper_bounds:
1716
max_memory_usage: 8.0e+9
1817

tests/unit/Execution/test_lbs_runtime.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,10 @@ def setUp(self):
8787
}
8888
}
8989
objects = phase.get_objects()
90-
alpha = 0.0
9190
beta = 1.0
9291
gamma = 0.0
9392
n_ranks = 4
94-
self.arrangements = compute_min_max_arrangements_work(objects, alpha, beta, gamma,
93+
self.arrangements = compute_min_max_arrangements_work(objects, 0.0, beta, gamma,
9594
n_ranks, logger=self.logger)[2]
9695
# Initialize the Runtime instances
9796
self.runtime = Runtime(

tests/unit/IO/test_configuration_validator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test_config_validator_wrong_work_model_parameters_missing(self):
145145
with self.assertRaises(SchemaError) as err:
146146
ConfigurationValidator(config_to_validate=configuration, logger=get_logger()).main()
147147
self.assertEqual(err.exception.args[0], "Key 'work_model' error:\nKey 'parameters' error:\n"
148-
"Missing key: 'alpha'")
148+
"Missing key: 'beta'")
149149

150150
def test_config_validator_wrong_work_model_parameters_type(self):
151151
with open(os.path.join(self.config_dir, "conf_wrong_work_model_parameters_type.yml"), "rt", encoding="utf-8") as config_file:

tests/unit/config/conf_wrong_work_model_parameters_missing.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ from_data:
88
work_model:
99
name: AffineCombination
1010
parameters:
11-
beta: 0.0
1211
gamma: 0.0
1312

1413
# Specify algorithm

0 commit comments

Comments
 (0)