Skip to content

Commit 0ecf3e9

Browse files
committed
#10: revise comments to be more accurate
1 parent c24dc67 commit 0ecf3e9

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

detection/core/SlowNodeDetector.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ def __sortNodesByExecutionTime(self, nodes: list):
144144

145145
def __sortNodesByMaxRankExecutionTime(self, nodes: list):
146146
"""
147-
Takes in a list of node names and sorts them based on total execution time.
148-
The fastest nodes will be first, and the slowest will be last.
147+
Takes in a list of node names and sorts them based on maximum rank
148+
execution time on the node. The fastest nodes will be first, and the
149+
slowest will be last.
149150
"""
150151
node_times = {}
151152
for r, n in self.__rank_to_node_map.items():
@@ -174,8 +175,9 @@ def __sortNodesByNodeDevFromAvgExecutionTime(self, nodes: list):
174175

175176
def __sortNodesByRankDevFromAvgExecutionTime(self, nodes: list):
176177
"""
177-
Takes in a list of node names and sorts them based on how much they deviate
178-
from the average total execution time.
178+
Takes in a list of node names and sorts them based on the maximum
179+
rank deviation from the rank-avg execution time.
180+
179181
"""
180182
avg = np.mean(list(self.__rank_times.values()))
181183
node_dev_times = {}

0 commit comments

Comments
 (0)