Skip to content

Commit 8be6144

Browse files
authored
Merge pull request #149 from DARMA-tasking/148-add-fmt-11-support
#148: make vt-tv work with fmt v11
2 parents 9d294fd + e5482a5 commit 8be6144

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ set(PROJECT_APP_DIR ${CMAKE_CURRENT_SOURCE_DIR}/apps)
7171
set(PROJECT_BINDINGS_DIR ${CMAKE_CURRENT_SOURCE_DIR}/bindings)
7272

7373
add_subdirectory(src)
74+
link_openmp()
7475
add_subdirectory(examples)
7576

7677
add_subdirectory(apps)

cmake/load_openmp.cmake

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,9 @@ else ()
88
message(STATUS "Did not find OpenMP")
99
set(VT_TV_OPENMP_ENABLED OFF)
1010
endif()
11+
12+
function(link_openmp)
13+
if(VT_TV_OPENMP_ENABLED)
14+
target_link_libraries(${VT_TV_LIBRARY} PUBLIC OpenMP::OpenMP_CXX)
15+
endif()
16+
endfunction()

tests/unit/render/test_render.cc

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -255,15 +255,10 @@ TEST_P(RenderTest, test_render_from_config_with_png) {
255255
output_file_stem,
256256
output_file_stem,
257257
i);
258-
std::vector<std::string> cmd_vars = {
259-
fmt::format("ACTUAL={}", png_file),
260-
fmt::format("EXPECTED={}", expected_png_file),
261-
"TOLERANCE=0.1",
262-
};
263258
auto cmd = fmt::format(
264-
"{} {}/tests/test_image.sh",
265-
fmt::join(cmd_vars, " "),
266-
SRC_DIR
259+
"ACTUAL={} EXPECTED={} TOLERANCE=0.1 "
260+
"{}/tests/test_image.sh",
261+
png_file, expected_png_file, SRC_DIR
267262
);
268263
cout << cmd << endl;
269264
const auto [status, output] = Util::exec(cmd.c_str());
@@ -388,4 +383,4 @@ TEST_F(RenderTest, test_render_construct_from_info) {
388383
SUCCEED();
389384
}
390385

391-
} // namespace vt::tv::tests::unit::render
386+
} // namespace vt::tv::tests::unit::render

0 commit comments

Comments
 (0)