#2435: lb: factor out ClusterInfo inter cluster and obj edge addition

Author: lifflander

src/vt/vrt/collection/balance/temperedlb/tempered_msgs.h

@@ -70,6 +70,22 @@ struct ClusterInfo {
   BytesType max_object_serialized_bytes_outside = 0;
   BytesType cluster_footprint = 0;
 
+  void addInterClusterEdge(bool is_send, SharedIDType id, double volume) {
+    if (is_send) {
+      inter_cluster_send_vol[id] += volume;
+    } else {
+      inter_cluster_recv_vol[id] += volume;
+    }
+  }
+
+  void addObjEdge(bool is_send, elm::ElementIDStruct obj, double volume) {
+    if (is_send) {
+      obj_send_vol[obj] += volume;
+    } else {
+      obj_recv_vol[obj] += volume;
+    }
+  }
+
   template <typename SerializerT>
   void serialize(SerializerT& s) {
     s | load | shared_id | bytes | intra_send_vol | intra_recv_vol;

src/vt/vrt/collection/balance/temperedlb/temperedlb.cc

@@ -676,22 +676,14 @@ void TemperedLB::makeClusterSummaryAddEdges(
         info.intra_recv_vol += volume;
       }
 
-      // intra-cluster (self-edge)
-      if (is_send) {
-        info.inter_cluster_send_vol[shared_id] += volume;
-      } else {
-        info.inter_cluster_recv_vol[shared_id] += volume;
-      }
+      // iter-cluster
+      info.addInterClusterEdge(is_send, shared_id, volume);
     } else if (
       auto it2 = obj_shared_block_.find(send_or_recv_obj);
       it2 != obj_shared_block_.end()
     ) {
       // inter-cluster edge
-      if (is_send) {
-        info.inter_cluster_send_vol[it2->second] += volume;
-      } else {
-        info.inter_cluster_recv_vol[it2->second] += volume;
-      }
+      info.addInterClusterEdge(is_send, it2->second, volume);
 
       vt_debug_print(
         verbose, temperedlb,
@@ -704,11 +696,7 @@ void TemperedLB::makeClusterSummaryAddEdges(
 
     } else {
       // across-object edge not part of a cluster
-      if (is_send) {
-        info.obj_send_vol[send_or_recv_obj] += volume;
-      } else {
-        info.obj_recv_vol[send_or_recv_obj] += volume;
-      }
+      info.addObjEdge(is_send, send_or_recv_obj, volume);
     }
   }
 }