#2388: move write_stats_event to lb manager

Author: cwschilly

src/vt/trace/trace.cc

@@ -84,7 +84,6 @@ void Trace::initialize() /*override*/ {
 
   // Register a trace user event to demarcate flushes that occur
   flush_event_ = trace::registerEventCollective("trace_flush");
-  write_stats_event_ = trace::registerEventCollective("write_lb_stats");
 #endif
 }
 

src/vt/trace/trace_lite.h

@@ -295,15 +295,6 @@ struct TraceLite  {
     return traces_.size();
   }
 
-  /**
-   * @brief Get the LB Stats Write event
-   *
-   * @return the LB stats write event
-   */
-  UserEventIDType getWriteStatsEvent() const {
-    return write_stats_event_;
-  }
-
   /**
    * @brief Get the last recorded trace event
    *
@@ -439,21 +430,20 @@ struct TraceLite  {
   EventHoldStackType event_holds_;
   TraceStackType open_events_;
   TraceContainerType traces_;
-  TraceEventIDType cur_event_         = 1;
-  UserEventIDType write_stats_event_  = no_user_event_id;
-  UserEventIDType flush_event_        = no_user_event_id;
-  bool enabled_                       = true;
-  TimeType start_time_                = TimeType{0.0};
-  std::string prog_name_              = "";
-  std::string trace_name_             = "";
-  std::string full_trace_name_        = "";
-  std::string full_sts_name_          = "";
-  std::string full_dir_name_          = "";
-  bool wrote_sts_file_                = false;
-  size_t trace_write_count_           = 0;
-  bool standalone_initalized_         = false;
-  bool trace_enabled_cur_phase_       = true;
-  bool idle_begun_                    = false;
+  TraceEventIDType cur_event_   = 1;
+  UserEventIDType flush_event_  = no_user_event_id;
+  bool enabled_                 = true;
+  TimeType start_time_          = TimeType{0.0};
+  std::string prog_name_        = "";
+  std::string trace_name_       = "";
+  std::string full_trace_name_  = "";
+  std::string full_sts_name_    = "";
+  std::string full_dir_name_    = "";
+  bool wrote_sts_file_          = false;
+  size_t trace_write_count_     = 0;
+  bool standalone_initalized_   = false;
+  bool trace_enabled_cur_phase_ = true;
+  bool idle_begun_              = false;
   std::unique_ptr<vt_gzFile> log_file_;
   std::unordered_map<TraceEventIDType, std::stack<Log*>> incomplete_notes_ = {};
 };

src/vt/vrt/collection/balance/lb_invoke/lb_manager.cc

@@ -463,6 +463,10 @@ void LBManager::startup() {
     thePhase()->printSummary(last_phase_info_.get());
     theLBManager()->finishedLB(phase);
   });
+
+  #if vt_check_enabled(trace_enabled)
+  write_stats_event_ = theTrace()->registerUserEventColl("write_lb_stats");
+  #endif
 }
 
 void LBManager::destroyLB() {
@@ -667,8 +671,7 @@ void LBManager::commitPhaseStatistics(PhaseType phase) {
   }
 
   #if vt_check_enabled(trace_enabled)
-  auto write_lb_stats_event = theTrace()->getWriteStatsEvent();
-  theTrace()->addUserEventBracketedBegin(write_lb_stats_event);
+  theTrace()->addUserEventBracketedBegin(write_stats_event_);
   #endif
 
   vt_debug_print(
@@ -689,7 +692,7 @@ void LBManager::commitPhaseStatistics(PhaseType phase) {
   writer->commitStaged();
 
   #if vt_check_enabled(trace_enabled)
-  theTrace()->addUserEventBracketedEnd(write_lb_stats_event);
+  theTrace()->addUserEventBracketedEnd(write_stats_event_);
   #endif
 }
 

src/vt/vrt/collection/balance/lb_invoke/lb_manager.h

@@ -55,6 +55,10 @@
 #include "vt/vrt/collection/balance/lb_invoke/phase_info.h"
 #include "vt/utils/json/base_appender.h"
 
+#if vt_check_enabled(trace_enabled)
+#include "vt/trace/trace_common.h"
+#endif
+
 #include <functional>
 #include <map>
 #include <unordered_map>
@@ -213,6 +217,9 @@ struct LBManager : runtime::component::Component<LBManager> {
       | model_
       | lb_instances_
       | stats
+      #if vt_check_enabled(trace_enabled)
+      | write_stats_event_
+      #endif
       | created_lbstats_dir_;
   }
 
@@ -305,6 +312,10 @@ struct LBManager : runtime::component::Component<LBManager> {
   bool before_lb_stats_ = true;
   /// The appender for outputting statistics in JSON format
   std::unique_ptr<util::json::BaseAppender> statistics_writer_ = nullptr;
+  /// Event ID for writing out the LB stats
+  #if vt_check_enabled(trace_enabled)
+  trace::UserEventIDType write_stats_event_ = trace::no_user_event_id;
+  #endif
   /// Whether the LB statistics directory has been created
   bool created_lbstats_dir_ = false;
 };