Fixing GroupCategory

Motivated by work in progress with PR #111. Communicating
breaking changes and configuring to change log and updating
behavior

Author: justin-lovell

CHANGELOG.md

@@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - `net.proto` - `GetPlayerInfo.remote_address`
   - `mission.proto` - `PlayerSendChatEvent.player_id`
 
+### Breaking Changes
+- Added `GROUP_CATEGORY_UNSPECIFIED` to `dcs.v0.common.GroupCategory`; breaking change as all indexes have changed.
+
 ## [0.3.0] - 2022-01-14
 ### Added
 - Generated scaffolding for the `net.*` scope into `NetService`

lua/DCS-gRPC/methods/coalitions.lua

@@ -106,13 +106,16 @@ local createGroundGroupTemplate = function(groupTemplate)
 end
 
 GRPC.methods.addGroup = function(params)
+  if params.groupCategory == 0 then
+    return GRPC.errorInvalidArgument("group category must be specified")
+  end
   if params.country_id == 0 or params.country_id == 15 then
     return GRPC.errorInvalidArgument("invalid country code")
   end
 
   local template = createGroundGroupTemplate(params.template.groundTemplate)
 
-  coalition.addGroup(params.country - 1, params.groupCategory, template) -- Decrement for non zero-indexed gRPC enum
+  coalition.addGroup(params.country - 1, params.groupCategory - 1, template) -- Decrement for non zero-indexed gRPC enum
 
   return GRPC.success({group = GRPC.exporters.group(Group.getByName(template.name))})
 end

protos/dcs/coalition/v0/coalition.proto

@@ -112,7 +112,7 @@ message AddGroupResponse {
 
 message GetGroupsRequest {
   dcs.common.v0.Coalition coalition = 1;
-  optional dcs.common.v0.GroupCategory category = 2;
+  dcs.common.v0.GroupCategory category = 2;
 }
 
 message GetGroupsResponse {

protos/dcs/common/v0/common.proto

@@ -231,11 +231,12 @@ message Group {
  * Group category enumerator.
  */
 enum GroupCategory {
-  GROUP_CATEGORY_AIRPLANE = 0;
-  GROUP_CATEGORY_HELICOPTER = 1;
-  GROUP_CATEGORY_GROUND = 2;
-  GROUP_CATEGORY_SHIP = 3;
-  GROUP_CATEGORY_TRAIN = 4;
+  GROUP_CATEGORY_UNSPECIFIED = 0;
+  GROUP_CATEGORY_AIRPLANE = 1;
+  GROUP_CATEGORY_HELICOPTER = 2;
+  GROUP_CATEGORY_GROUND = 3;
+  GROUP_CATEGORY_SHIP = 4;
+  GROUP_CATEGORY_TRAIN = 5;
 }
 
 /**