Skip to content

Commit baa4f03

Browse files
authored
Merge pull request #245 from DDD-Community/hotfix/home
hotfix: Home 관련 버그들 개선
2 parents e57174b + 9dbdeb1 commit baa4f03

File tree

3 files changed

+24
-11
lines changed

3 files changed

+24
-11
lines changed

src/composite/home/homeBanner/HomeBanner.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const HomeBanner = () => {
3434

3535
return (
3636
<div className="relative w-full h-[168px] overflow-hidden">
37-
<video className="absolute inset-0 w-full h-full object-cover" src={videoUrl} autoPlay loop muted playsInline />
37+
<video className="absolute inset-0 w-full h-full object-cover" src={videoUrl} autoPlay muted playsInline />
3838
{bannerMessage && (
3939
<div className="absolute top-1/4 left-4 z-10 max-w-[70%]">
4040
<p className="text-[18px] font-bold text-white leading-tight whitespace-pre-line">{bannerMessage}</p>

src/feature/todo/todoBottomSheet/form/TodoFormProvider.tsx

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use client';
22

3-
import { useCallback, createContext, useContext } from 'react';
3+
import { useCallback, createContext, useContext, useMemo } from 'react';
44
import { useForm, FormProvider, UseFormReturn } from 'react-hook-form';
55
import { zodResolver } from '@hookform/resolvers/zod';
66
import { format } from 'date-fns';
@@ -56,16 +56,30 @@ export const TodoFormProvider = ({ mode, values, selectedDate, todoId, onClose,
5656
// 선택된 날짜를 YYYY-MM-DD 형식으로 변환
5757
const initialDateString = format(selectedDate, 'yyyy-MM-dd');
5858

59-
// add 모드일 때 사용할 기본값 (date 포함)
60-
const addModeDefaults: TodoFormData = {
61-
...TODO_DEFAULT_VALUES,
62-
date: initialDateString,
63-
};
59+
// add 모드일 때 사용할 기본값 (date 포함) - selectedDate 변경 시에만 재계산
60+
const addModeDefaults = useMemo<TodoFormData>(
61+
() => ({
62+
...TODO_DEFAULT_VALUES,
63+
date: initialDateString,
64+
}),
65+
[initialDateString]
66+
);
67+
68+
// form의 values 옵션: add 모드일 때도 selectedDate 변경을 반영
69+
const formValues = useMemo(() => {
70+
if (mode === 'edit' && values) {
71+
return values;
72+
}
73+
if (mode === 'add') {
74+
return addModeDefaults;
75+
}
76+
return undefined;
77+
}, [mode, values, addModeDefaults]);
6478

6579
const methods = useForm<TodoFormData>({
6680
resolver: zodResolver(todoFormSchema),
6781
defaultValues: addModeDefaults,
68-
values: mode === 'edit' && values ? values : undefined,
82+
values: formValues,
6983
mode: 'onSubmit',
7084
shouldUnregister: false,
7185
});

src/model/todo/todoList/api.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,8 @@ export const todoListApi = {
2727
},
2828

2929
putTodo: async (req: PutTodoRequest) => {
30-
const { todoId, routineUpdateType, ...putReq } = req;
31-
const queryParam = routineUpdateType ? `?routineUpdateType=${routineUpdateType}` : '';
32-
const { data } = await apiClient.put<CommonResponse<TodoResponse>>(`/todos/${todoId}${queryParam}`, putReq);
30+
const { todoId, ...putReq } = req;
31+
const { data } = await apiClient.put<CommonResponse<TodoResponse>>(`/todos/${todoId}`, putReq);
3332
return data.data;
3433
},
3534

0 commit comments

Comments
 (0)