Feature/ultip 5215 #706
check-pull-request.yml
on: pull_request
Run Pull Request Checks
2m 36s
Run Integration Tests
3m 28s
CDP SonarCloud Scan
/
CDP SonarCloud coverage scan
3m 2s
Annotations
13 warnings
|
Run Pull Request Checks
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3, actions/setup-dotnet@v3, marocchino/sticky-pull-request-comment@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4, actions/checkout@v4, actions/setup-dotnet@v3, actions/setup-java@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/DTOs/SiteTypeDTO.cs#L52
Rename class 'SiteActivityInfoDTO' to match pascal case naming rules, consider using 'SiteActivityInfoDto'.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/DTOs/SiteTypeDTO.cs#L32
Rename class 'SiteTypeInfoDTO' to match pascal case naming rules, consider using 'SiteTypeInfoDto'.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/DTOs/SiteTypeDTO.cs#L8
Rename class 'SiteTypeDTO' to match pascal case naming rules, consider using 'SiteTypeDto'.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/DTOs/IdentifierTypeDTO.cs#L8
Rename class 'IdentifierTypeDTO' to match pascal case naming rules, consider using 'IdentifierTypeDto'.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/DTOs/CountryDTO.cs#L8
Rename class 'CountryDTO' to match pascal case naming rules, consider using 'CountryDto'.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/Domain/Sites/Formatters/AddressFormatters.cs#L101
Remove the unused private method 'AddSaonLabel'.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/Storage/IStorageReader.cs#L3
'T' is not used in the interface.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/Documents/Reference/IReferenceListDocument.cs#L9
A static field in a generic type is not shared among instances of different close constructed types.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
src/KeeperData.Core/Messaging/MessagePublishers/IMessagePublisher.cs#L3
'T' is not used in the interface.
|
|
CDP SonarCloud Scan / CDP SonarCloud coverage scan:
tools/TsvToJsonConverter/DataConverter/GenericTsvConverter.cs#L40
Make this an auto-implemented property and remove its backing field.
|
|
Run Integration Tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v3, actions/setup-dotnet@v3. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|