Skip to content

Commit 7c24aab

Browse files
committed
Correct container/image name
1 parent f3e8361 commit 7c24aab

5 files changed

Lines changed: 11 additions & 10 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ env:
1414
MIN_LINE_COVERAGE: "70"
1515
WEB_SOLUTION_FILE: SchoolAccount.Web.slnx
1616
MAIN_BRANCH: refs/heads/main
17+
IMAGE_NAME: ghcr.io/dfe-digital/schoolaccount-web
1718

1819
jobs:
1920
build:
@@ -84,7 +85,7 @@ jobs:
8485
id: meta
8586
uses: docker/metadata-action@v6
8687
with:
87-
images: ghcr.io/dfe-digital/schoolaccount-presentation
88+
images: ${{ env.IMAGE_NAME }}
8889
tags: |
8990
type=sha
9091
type=raw,value=latest,enable=${{ github.ref == env.MAIN_BRANCH }}

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,21 +158,21 @@ is available at http://localhost:8081.
158158

159159
## Published Docker Image
160160

161-
The Web project is published to the [GitHub Container Registry](https://github.com/DFE-Digital/SchoolAccount-Web/pkgs/container/schoolaccount-presentation)
161+
The Web project is published to the [GitHub Container Registry](https://github.com/DFE-Digital/SchoolAccount-Web/pkgs/container/schoolaccount-web)
162162
as a Docker image that can be pulled down and run.
163163
The image is created on every push to the `main` branch and tagged with the current commit SHA and the latest tag.
164164

165165
To verify the image locally, you can run:
166166
```
167-
docker run --platform linux/amd64 --name presentation -e OpenIDConnectSettings__ClientId=SA_TEST_CLIENT -e OpenIDConnectSettings__Authority=https://localhost:7041 -p 5100:8080 -d ghcr.io/dfe-digital/schoolaccount-presentation:latest
167+
docker run --platform linux/amd64 --name web -e OpenIDConnectSettings__ClientId=SA_TEST_CLIENT -e OpenIDConnectSettings__Authority=https://localhost:7041 -p 5100:8080 -d ghcr.io/dfe-digital/schoolaccount-web:latest
168168
```
169169

170170
You can then test the Web project by visiting http://localhost:5100.
171171

172172
To stop and delete the container, you can run:
173173
```
174-
docker stop presentation
175-
docker rm presentation
174+
docker stop web
175+
docker rm web
176176
```
177177

178178
## Contributing

decisions/0010-use-containerisation-to-publish-code.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ Chosen option: "Use containerisation to publish code", because it aligns with Df
3535

3636
### Confirmation
3737

38-
The image has been build and published to the [container registry](https://github.com/DFE-Digital/SchoolAccount-Web/pkgs/container/schoolaccount-presentation).
38+
The image has been build and published to the [container registry](https://github.com/DFE-Digital/SchoolAccount-Web/pkgs/container/schoolaccount-web).

docker-compose.override.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
services:
2-
presentation:
2+
web:
33
environment:
44
- ASPNETCORE_ENVIRONMENT=Development
55
- ASPNETCORE_HTTP_PORTS=8080

docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
services:
2-
presentation:
3-
image: ${DOCKER_REGISTRY-}presentation
4-
container_name: presentation
2+
web:
3+
image: ${DOCKER_REGISTRY-}web
4+
container_name: web
55
build:
66
context: .
77
dockerfile: src/SchoolAccount.Web.Mvc/Dockerfile

0 commit comments

Comments
 (0)