Annotate ts as PointModelResult | NodeModelResult in load()

jpalm3r · jpalm3r · commit 7b52f8631d3d · 2026-07-24T16:04:46.000+02:00
mypy inferred ts's type from its first assignment (NodeModelResult), flagging the later PointModelResult assignment as incompatible. Part of gh #677
diff --git a/src/modelskill/comparison/_comparison.py b/src/modelskill/comparison/_comparison.py
@@ -1412,6 +1412,7 @@ def load(filename: Union[str, Path]) -> "Comparer":
                     ds = data[[var_name]].rename(
                         {"_time_raw_" + new_key: "time", var_name: new_key}
                     )
+                    ts: PointModelResult | NodeModelResult
                     if data.gtype == "node":
                         ts = NodeModelResult(
                             data=ds, node=int(ds.coords["node"].item()), name=new_key

Original file line number	Diff line number	Diff line change
`@@ -1412,6 +1412,7 @@ def load(filename: Union[str, Path]) -> "Comparer":`
`1412`	`1412`	`ds = data[[var_name]].rename(`
`1413`	`1413`	`{"_time_raw_" + new_key: "time", var_name: new_key}`
`1414`	`1414`	`)`
	`1415`	`+ ts: PointModelResult \| NodeModelResult`
`1415`	`1416`	`if data.gtype == "node":`
`1416`	`1417`	`ts = NodeModelResult(`
`1417`	`1418`	`data=ds, node=int(ds.coords["node"].item()), name=new_key`