Skip to content

Commit 49cdf55

Browse files
m-dhellinm-dhellin
committed
Formatted some files.
1 parent d02a9c2 commit 49cdf55

5 files changed

Lines changed: 171 additions & 235 deletions

File tree

‎plugins/backup/backroll/src/main/java/org/apache/cloudstack/backup/BackrollBackupProvider.java‎

Lines changed: 46 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,14 @@ public class BackrollBackupProvider extends AdapterBase implements BackupProvide
5353

5454
public static final String BACKUP_IDENTIFIER = "-CSBKP-";
5555

56-
public ConfigKey<String> BackrollUrlConfigKey = new ConfigKey<>("Advanced", String.class,
57-
"backup.plugin.backroll.config.url",
58-
"http://api.backup.demo.ccc:5050/api/v1",
59-
"Url for backroll plugin.", true, ConfigKey.Scope.Zone);
56+
public ConfigKey<String> BackrollUrlConfigKey = new ConfigKey<>("Advanced", String.class, "backup.plugin.backroll.config.url", "http://api.backup.demo.ccc:5050/api/v1",
57+
"Url for backroll plugin.", true, ConfigKey.Scope.Zone);
6058

61-
public ConfigKey<String> BackrollAppNameConfigKey = new ConfigKey<>("Advanced", String.class,
62-
"backup.plugin.backroll.config.appname",
63-
"backroll-api",
64-
"App Name for backroll plugin.", true, ConfigKey.Scope.Zone);
59+
public ConfigKey<String> BackrollAppNameConfigKey = new ConfigKey<>("Advanced", String.class, "backup.plugin.backroll.config.appname", "backroll-api",
60+
"App Name for backroll plugin.", true, ConfigKey.Scope.Zone);
6561

66-
public ConfigKey<String> BackrollPasswordConfigKey = new ConfigKey<>("Advanced", String.class,
67-
"backup.plugin.backroll.config.password",
68-
"VviX8dALauSyYJMqVYJqf3UyZOpO3joS",
69-
"Password for backroll plugin.", true, ConfigKey.Scope.Zone);
62+
public ConfigKey<String> BackrollPasswordConfigKey = new ConfigKey<>("Advanced", String.class, "backup.plugin.backroll.config.password", "VviX8dALauSyYJMqVYJqf3UyZOpO3joS",
63+
"Password for backroll plugin.", true, ConfigKey.Scope.Zone);
7064

7165
private BackrollClient backrollClient;
7266

@@ -75,15 +69,16 @@ public class BackrollBackupProvider extends AdapterBase implements BackupProvide
7569
@Inject
7670
private VMInstanceDao vmInstanceDao;
7771

78-
public BackrollBackupProvider(BackupDao backupDao, VMInstanceDao vmInstanceDao, BackrollClient client, Logger logger){
72+
public BackrollBackupProvider(BackupDao backupDao, VMInstanceDao vmInstanceDao, BackrollClient client, Logger logger) {
7973
this.backupDao = backupDao;
8074
this.vmInstanceDao = vmInstanceDao;
8175
this.backrollClient = client;
8276
this.logger = logger;
8377
}
8478

85-
public BackrollBackupProvider(){}
86-
79+
public BackrollBackupProvider() {
80+
}
81+
8782
private Map<VirtualMachine, Backup.Metric> backupFilesMetricsMap = new HashMap<>();
8883

8984
@Override
@@ -100,7 +95,7 @@ public String getDescription() {
10095
public List<BackupOffering> listBackupOfferings(Long zoneId) {
10196
logger.debug("Listing backup policies on backroll B&R Plugin");
10297
BackrollClient client = getClient(zoneId);
103-
try{
98+
try {
10499
var results = client.getBackupOfferings();
105100

106101
logger.info("BackrollProvider: results " + (results.size() > 0 ? "> 0" : "<= 0"));
@@ -120,9 +115,9 @@ public boolean isValidProviderOffering(Long zoneId, String uuid) {
120115
@Override
121116
public boolean assignVMToBackupOffering(VirtualMachine vm, BackupOffering backupOffering) {
122117
logger.info("Creating VM backup for VM {} from backup offering {}", vm.getInstanceName(), backupOffering.getName());
123-
if(vm instanceof VMInstanceVO) {
124-
((VMInstanceVO) vm).setBackupExternalId(backupOffering.getUuid());
125-
118+
if (vm instanceof VMInstanceVO) {
119+
((VMInstanceVO)vm).setBackupExternalId(backupOffering.getUuid());
120+
126121
return true;
127122
}
128123
return false;
@@ -133,7 +128,7 @@ public boolean restoreVMFromBackup(VirtualMachine vm, Backup backup) {
133128
logger.debug("Restoring vm {} from backup {} on the backroll Backup Provider", vm.getUuid(), backup.getUuid());
134129

135130
try {
136-
return getClient(vm.getDataCenterId()).restoreVMFromBackup(vm.getUuid(), getBackupName(backup));
131+
return getClient(vm.getDataCenterId()).restoreVMFromBackup(vm.getUuid(), getBackupName(backup));
137132
} catch (ParseException | BackrollApiException | IOException e) {
138133
throw new CloudRuntimeException("Failed to restore VM from Backup");
139134
}
@@ -173,7 +168,7 @@ private Map<VirtualMachine, Backup.Metric> getBackupMetrics(Long zoneId, List<Vi
173168
logger.debug("backroll backup id: {}", backup.getExternalId());
174169
logger.debug("backroll backup status: {}", response.getState());
175170

176-
BackupVO backupToUpdate = ((BackupVO) backup);
171+
BackupVO backupToUpdate = ((BackupVO)backup);
177172

178173
if (response.getState().equals("PENDING")) {
179174
backupToUpdate.setStatus(Backup.Status.BackingUp);
@@ -185,7 +180,7 @@ private Map<VirtualMachine, Backup.Metric> getBackupMetrics(Long zoneId, List<Vi
185180

186181
BackrollBackupMetrics backupMetrics = null;
187182
try {
188-
backupMetrics = client.getBackupMetrics(vm.getUuid() , response.getInfo());
183+
backupMetrics = client.getBackupMetrics(vm.getUuid(), response.getInfo());
189184
if (backupMetrics != null) {
190185
backupToUpdate.setProtectedSize(backupMetrics.getDeduplicated());
191186
backupToUpdate.setSize(backupMetrics.getSize());
@@ -203,12 +198,12 @@ private Map<VirtualMachine, Backup.Metric> getBackupMetrics(Long zoneId, List<Vi
203198
}
204199
}
205200
} else {
206-
if(backup.getExternalId().contains(",")) {
201+
if (backup.getExternalId().contains(",")) {
207202
String backupId = backup.getExternalId().split(",")[1];
208-
BackupVO backupToUpdate = ((BackupVO) backup);
203+
BackupVO backupToUpdate = ((BackupVO)backup);
209204
backupToUpdate.setExternalId(backupId);
210205
try {
211-
BackrollBackupMetrics backupMetrics = client.getBackupMetrics(vm.getUuid() , backupId);
206+
BackrollBackupMetrics backupMetrics = client.getBackupMetrics(vm.getUuid(), backupId);
212207
if (backupMetrics != null) {
213208
backupToUpdate.setProtectedSize(backupMetrics.getDeduplicated());
214209
backupToUpdate.setSize(backupMetrics.getSize());
@@ -232,19 +227,16 @@ private Map<VirtualMachine, Backup.Metric> getBackupMetrics(Long zoneId, List<Vi
232227
List<RestorePoint> backups = client.listRestorePoints(vm.getUuid());
233228
for (RestorePoint backup : backups) {
234229

235-
BackrollBackupMetrics backupMetrics = client.getBackupMetrics(vm.getUuid() , getBackupName(backup.getId()));
230+
BackrollBackupMetrics backupMetrics = client.getBackupMetrics(vm.getUuid(), getBackupName(backup.getId()));
236231
if (backupMetrics != null) {
237232
usedSize += Long.valueOf(backupMetrics.getDeduplicated());
238233
dataSize += Long.valueOf(backupMetrics.getSize());
239234

240235
// update backup metrics
241-
Backup backupToFind = backupsInDb.stream()
242-
.filter(backupInDb -> backupInDb.getExternalId().contains(backup.getId()))
243-
.findAny()
244-
.orElse(null);
236+
Backup backupToFind = backupsInDb.stream().filter(backupInDb -> backupInDb.getExternalId().contains(backup.getId())).findAny().orElse(null);
245237

246238
if (backupToFind != null) {
247-
BackupVO backupToUpdate = ((BackupVO) backupToFind);
239+
BackupVO backupToUpdate = ((BackupVO)backupToFind);
248240
backupToUpdate.setProtectedSize(usedSize);
249241
backupToUpdate.setSize(dataSize);
250242
backupDao.persist(backupToUpdate);
@@ -253,8 +245,8 @@ private Map<VirtualMachine, Backup.Metric> getBackupMetrics(Long zoneId, List<Vi
253245
}
254246
}
255247
Metric metric = new Metric(dataSize, usedSize);
256-
logger.debug("Metrics for VM [uuid: {}, name: {}] is [backup size: {}, data size: {}].", vm.getUuid(),
257-
vm.getInstanceName(), metric.getBackupSize(), metric.getDataSize());
248+
logger.debug("Metrics for VM [uuid: {}, name: {}] is [backup size: {}, data size: {}].", vm.getUuid(), vm.getInstanceName(), metric.getBackupSize(),
249+
metric.getDataSize());
258250
metrics.put(vm, metric);
259251
} catch (BackrollApiException | IOException e) {
260252
throw new CloudRuntimeException("Failed to retrieve backup metrics");
@@ -280,11 +272,11 @@ public Pair<Boolean, Backup> takeBackup(VirtualMachine vm, Boolean quiesceVM) {
280272

281273
try {
282274
String backupExternalId = client.startBackupJob(vm.getUuid());
283-
275+
284276
if (StringUtils.isEmpty(backupExternalId)) {
285-
return new Pair<>(false, null);
277+
return new Pair<>(false, null);
286278
}
287-
279+
288280
var backup = new BackupVO();
289281
backup.setVmId(vm.getId());
290282
backup.setExternalId(backupExternalId);
@@ -297,10 +289,10 @@ public Pair<Boolean, Backup> takeBackup(VirtualMachine vm, Boolean quiesceVM) {
297289
backup.setAccountId(vm.getAccountId());
298290
backup.setDomainId(vm.getDomainId());
299291
backup.setZoneId(vm.getDataCenterId());
300-
292+
301293
Boolean result = backupDao.persist(backup) != null;
302-
303-
return new Pair<Boolean,Backup>(result, backup);
294+
295+
return new Pair<Boolean, Backup>(result, backup);
304296

305297
} catch (ParseException | BackrollApiException | IOException e) {
306298
logger.debug(e.getMessage());
@@ -315,11 +307,7 @@ public String getConfigComponentName() {
315307

316308
@Override
317309
public ConfigKey<?>[] getConfigKeys() {
318-
return new ConfigKey[]{
319-
BackrollUrlConfigKey,
320-
BackrollAppNameConfigKey,
321-
BackrollPasswordConfigKey
322-
};
310+
return new ConfigKey[] {BackrollUrlConfigKey, BackrollAppNameConfigKey, BackrollPasswordConfigKey};
323311
}
324312

325313
@Override
@@ -330,7 +318,7 @@ public boolean deleteBackup(Backup backup, boolean forced) {
330318
} else {
331319
logger.debug("BACKROLL: try delete backup");
332320

333-
if (backup.getStatus().equals(Backup.Status.Removed) || backup.getStatus().equals(Backup.Status.Failed)){
321+
if (backup.getStatus().equals(Backup.Status.Removed) || backup.getStatus().equals(Backup.Status.Failed)) {
334322
return deleteBackupInDb(backup);
335323
} else {
336324
VMInstanceVO vm = vmInstanceDao.findByIdIncludingRemoved(backup.getVmId());
@@ -349,7 +337,7 @@ public boolean deleteBackup(Backup backup, boolean forced) {
349337
}
350338

351339
private boolean deleteBackupInDb(Backup backup) {
352-
BackupVO backupToUpdate = ((BackupVO) backup);
340+
BackupVO backupToUpdate = ((BackupVO)backup);
353341
backupToUpdate.setStatus(Backup.Status.Removed);
354342
if (backupDao.persist(backupToUpdate) != null) {
355343
logger.debug("BACKROLL: Backroll backup {} deleted in database.", backup.getUuid());
@@ -363,7 +351,8 @@ private BackrollClient getClient(final Long zoneId) {
363351
try {
364352
if (backrollClient == null) {
365353
logger.debug("backroll client null - instantiation of new one ");
366-
BackrollHttpClientProvider provider = BackrollHttpClientProvider.createProvider(new BackrollHttpClientProvider(), BackrollUrlConfigKey.valueIn(zoneId), BackrollAppNameConfigKey.valueIn(zoneId), BackrollPasswordConfigKey.valueIn(zoneId), true, 300, 600);
354+
BackrollHttpClientProvider provider = BackrollHttpClientProvider.createProvider(new BackrollHttpClientProvider(), BackrollUrlConfigKey.valueIn(zoneId),
355+
BackrollAppNameConfigKey.valueIn(zoneId), BackrollPasswordConfigKey.valueIn(zoneId), true, 300, 600);
367356
backrollClient = new BackrollClient(provider);
368357
}
369358
return backrollClient;
@@ -385,7 +374,8 @@ private String getBackupName(String externalId) {
385374
}
386375

387376
@Override
388-
public Pair<Boolean, String> restoreBackedUpVolume(Backup backup, Backup.VolumeInfo backupVolumeInfo, String hostIp, String dataStoreUuid, Pair<String, VirtualMachine.State> vmNameAndState) {
377+
public Pair<Boolean, String> restoreBackedUpVolume(Backup backup, Backup.VolumeInfo backupVolumeInfo, String hostIp, String dataStoreUuid,
378+
Pair<String, VirtualMachine.State> vmNameAndState) {
389379
logger.debug("Restoring volume {} from backup {} on the Backroll Backup Provider", backupVolumeInfo.getUuid(), backup.getUuid());
390380
throw new CloudRuntimeException("Backroll plugin does not support this feature");
391381
}
@@ -416,7 +406,7 @@ public Backup createNewBackupEntryForRestorePoint(RestorePoint restorePoint, Vir
416406
backupToInsert.setZoneId(vm.getDataCenterId());
417407

418408
try {
419-
BackrollBackupMetrics backupMetrics = client.getBackupMetrics(vm.getUuid() , getBackupName(restorePoint.getId()));
409+
BackrollBackupMetrics backupMetrics = client.getBackupMetrics(vm.getUuid(), getBackupName(restorePoint.getId()));
420410
if (backupMetrics != null) {
421411
backupToInsert.setProtectedSize(backupMetrics.getDeduplicated());
422412
backupToInsert.setSize(backupMetrics.getSize());
@@ -436,16 +426,17 @@ public Boolean crossZoneInstanceCreationEnabled(BackupOffering backupOffering) {
436426

437427
@Override
438428
public Pair<Boolean, String> restoreBackupToVM(VirtualMachine vm, Backup backup, String hostIp, String dataStoreUuid) {
439-
throw new UnsupportedOperationException("Not supported yet."); // Generated from nbfs://nbhost/SystemFileSystem/Templates/Classes/Code/GeneratedMethodBody
429+
throw new UnsupportedOperationException("Not supported yet."); // Generated from
430+
// nbfs://nbhost/SystemFileSystem/Templates/Classes/Code/GeneratedMethodBody
440431
}
441432

442433
@Override
443434
public void syncBackupMetrics(Long zoneId) {
444-
final List<VMInstanceVO> vms = vmInstanceDao.listByZoneId(zoneId);
445-
446-
final var castedVMList = vms.stream().map((v) -> (VirtualMachine)v).collect(Collectors.toList());
447-
448-
backupFilesMetricsMap = getBackupMetrics(zoneId, castedVMList);
435+
final List<VMInstanceVO> vms = vmInstanceDao.listByZoneId(zoneId);
436+
437+
final var castedVMList = vms.stream().map((v) -> (VirtualMachine)v).collect(Collectors.toList());
438+
439+
backupFilesMetricsMap = getBackupMetrics(zoneId, castedVMList);
449440
}
450441

451442
@Override

0 commit comments

Comments
 (0)