Skip to content

Commit 93cb40c

Browse files
chore: Update project name at imports
1 parent f142e9d commit 93cb40c

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

src/dirac_cwl/commands/upload_log_file.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
from DIRAC.Resources.Storage.StorageElement import StorageElement
1919
from DIRAC.WorkloadManagementSystem.Client.JobReport import JobReport
2020

21-
from dirac_cwl_proto.commands import PostProcessCommand
21+
from dirac_cwl.commands import PostProcessCommand
2222

2323

2424
class UploadLogFile(PostProcessCommand):
@@ -80,7 +80,9 @@ def execute(self, job_path, **kwargs):
8080
logHttpsURL = urljoin("https://lhcb-dirac-logse.web.cern.ch/lhcb-dirac-logse/", zip_lfn)
8181
else:
8282
logHttpsURL = result["Value"]
83-
job_report.setJobParameter("Log URL", f'<a href="{logHttpsURL.replace('.zip','/')}">Log file directory</a>')
83+
84+
logHttpsURL = logHttpsURL.replace('.zip','/')
85+
job_report.setJobParameter("Log URL", f'<a href="{logHttpsURL}">Log file directory</a>')
8486

8587
return S_OK("Log Files uploaded")
8688

test/test_commands.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from DIRACCommon.Core.Utilities.ReturnValues import S_ERROR, S_OK
99
from pytest_mock import MockerFixture
1010

11-
from dirac_cwl_proto.commands import UploadLogFile
11+
from dirac_cwl.commands import UploadLogFile
1212

1313

1414
class TestUploadLogFile:
@@ -54,18 +54,18 @@ def test_upload_ok(self, basedir, mocker: MockerFixture):
5454
expected_path = os.path.join(basedir, zip_name)
5555

5656
# Mock Operations
57-
mock_ops = mocker.patch("dirac_cwl_proto.commands.upload_log_file.Operations")
57+
mock_ops = mocker.patch("dirac_cwl.commands.upload_log_file.Operations")
5858
mock_ops.return_value.getValue = lambda value, default=None: default
5959

6060
# Mock JobReport
61-
mock_job_report = mocker.patch("dirac_cwl_proto.commands.upload_log_file.JobReport")
61+
mock_job_report = mocker.patch("dirac_cwl.commands.upload_log_file.JobReport")
6262
mock_set_app_status = mocker.MagicMock()
6363
mock_set_job_parameter = mocker.MagicMock()
6464
mock_job_report.return_value.setApplicationStatus = mock_set_app_status
6565
mock_job_report.return_value.setJobParameter = mock_set_job_parameter
6666

6767
# Mock StorageElement
68-
mock_se = mocker.patch("dirac_cwl_proto.commands.upload_log_file.StorageElement")
68+
mock_se = mocker.patch("dirac_cwl.commands.upload_log_file.StorageElement")
6969
mock_put_file = mocker.MagicMock()
7070
mock_get_url = mocker.MagicMock()
7171
mock_put_file.return_value = S_OK({"Successful": {expected_lfn: "Borked"}, "Failed": {}})
@@ -103,18 +103,18 @@ def test_upload_ok_to_failover(self, basedir, mocker: MockerFixture):
103103
expected_path = os.path.join(basedir, zip_name)
104104

105105
# Mock Operations
106-
mock_ops = mocker.patch("dirac_cwl_proto.commands.upload_log_file.Operations")
106+
mock_ops = mocker.patch("dirac_cwl.commands.upload_log_file.Operations")
107107
mock_ops.return_value.getValue = lambda value, default=None: default
108108

109109
# Mock JobReport
110-
mock_job_report = mocker.patch("dirac_cwl_proto.commands.upload_log_file.JobReport")
110+
mock_job_report = mocker.patch("dirac_cwl.commands.upload_log_file.JobReport")
111111
mock_set_app_status = mocker.MagicMock()
112112
mock_set_job_parameter = mocker.MagicMock()
113113
mock_job_report.return_value.setApplicationStatus = mock_set_app_status
114114
mock_job_report.return_value.setJobParameter = mock_set_job_parameter
115115

116116
# Mock StorageElement
117-
mock_se = mocker.patch("dirac_cwl_proto.commands.upload_log_file.StorageElement")
117+
mock_se = mocker.patch("dirac_cwl.commands.upload_log_file.StorageElement")
118118
mock_put_file = mocker.MagicMock()
119119
mock_get_url = mocker.MagicMock()
120120
mock_put_file.return_value = S_OK({"Successful": {}, "Failed": {expected_lfn: "Borked"}})
@@ -152,14 +152,14 @@ def test_upload_fail(self, basedir, mocker: MockerFixture):
152152
expected_path = os.path.join(basedir, zip_name)
153153

154154
# Mock JobReport
155-
mock_job_report = mocker.patch("dirac_cwl_proto.commands.upload_log_file.JobReport")
155+
mock_job_report = mocker.patch("dirac_cwl.commands.upload_log_file.JobReport")
156156
mock_set_app_status = mocker.MagicMock()
157157
mock_set_job_parameter = mocker.MagicMock()
158158
mock_job_report.return_value.setApplicationStatus = mock_set_app_status
159159
mock_job_report.return_value.setJobParameter = mock_set_job_parameter
160160

161161
# Mock StorageElement
162-
mock_se = mocker.patch("dirac_cwl_proto.commands.upload_log_file.StorageElement")
162+
mock_se = mocker.patch("dirac_cwl.commands.upload_log_file.StorageElement")
163163
mock_put_file = mocker.MagicMock()
164164
mock_get_url = mocker.MagicMock()
165165
mock_put_file.return_value = S_OK({"Successful": {}, "Failed": {expected_lfn: "Borked"}})
@@ -195,7 +195,7 @@ def test_no_files_to_zip(self, basedir, mocker):
195195
shutil.rmtree(basedir)
196196

197197
# Mock JobReport
198-
mock_job_report = mocker.patch("dirac_cwl_proto.commands.upload_log_file.JobReport")
198+
mock_job_report = mocker.patch("dirac_cwl.commands.upload_log_file.JobReport")
199199
mock_set_app_status = mocker.MagicMock()
200200
mock_set_job_parameter = mocker.MagicMock()
201201
mock_job_report.return_value.setApplicationStatus = mock_set_app_status
@@ -222,7 +222,7 @@ def test_failed_to_zip(self, basedir, mocker: MockerFixture):
222222
mock_zip.side_effect = [AttributeError(), OSError(), ValueError()]
223223

224224
# Mock JobReport
225-
mock_job_report = mocker.patch("dirac_cwl_proto.commands.upload_log_file.JobReport")
225+
mock_job_report = mocker.patch("dirac_cwl.commands.upload_log_file.JobReport")
226226
mock_set_app_status = mocker.MagicMock()
227227
mock_set_job_parameter = mocker.MagicMock()
228228
mock_job_report.return_value.setApplicationStatus = mock_set_app_status

0 commit comments

Comments
 (0)