Skip to content

Commit f62d9c1

Browse files
committed
dev: updated tests
1 parent 3699053 commit f62d9c1

File tree

6 files changed

+18
-22
lines changed

6 files changed

+18
-22
lines changed

test/test_execution_hooks_core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ def test_from_cwl(self, mocker):
177177
mock_cwl = mocker.Mock()
178178
mock_cwl.hints = [
179179
{
180-
"class": "dirac:execution-hooks",
180+
"class": "dirac:ExecutionHooksHint",
181181
"hook_plugin": "QueryBased",
182182
"campaign": "Run3",
183183
},
@@ -254,7 +254,7 @@ def test_from_cwl(self, mocker):
254254
mock_cwl = mocker.Mock()
255255
mock_cwl.hints = [
256256
{
257-
"class": "dirac:scheduling",
257+
"class": "dirac:SchedulingHint",
258258
"platform": "DIRAC-v8",
259259
"priority": 8,
260260
"sites": ["LCG.CERN.ch"],

test/test_workflows.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,12 @@ def pi_test_files():
8888
),
8989
# --- Test metadata example ---
9090
# A string input is passed
91-
# (
92-
# TODO doesn't work since it doesn't override anymore
93-
# "test/workflows/test_meta/test_meta.cwl",
94-
# [
95-
# "test/workflows/test_meta/override_dirac_hints.yaml",
96-
# ],
97-
# ),
91+
(
92+
"test/workflows/test_meta/test_meta.cwl",
93+
[
94+
"test/workflows/test_meta/override_dirac_hints.yaml",
95+
],
96+
),
9897
# --- Crypto example ---
9998
# Complete
10099
(

test/workflows/pi/description.cwl

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ doc: >
66
It generates random points in a square and calculates how many fall within
77
a unit circle inscribed in the square.
88

9+
$namespaces:
10+
dirac: "../../schemas/dirac-metadata.json#/$defs/"
11+
12+
$schemas:
13+
- "../../schemas/dirac-metadata.json"
14+
915
# Define the inputs of the workflow
1016
inputs:
1117
num-points:

test/workflows/pi/pigather.cwl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@ requirements:
66
coresMin: 1
77
ramMin: 1024
88

9-
$namespaces:
10-
dirac: "../../schemas/dirac-metadata.json#/$defs/"
11-
12-
$schemas:
13-
- "../../schemas/dirac-metadata.json"
14-
159
hints:
1610
$import: "type_dependencies/transformation/metadata-pi_gather.yaml"
1711

test/workflows/pi/pisimulate.cwl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@ requirements:
66
coresMin: 2
77
ramMin: 1024
88

9-
$namespaces:
10-
dirac: "../../schemas/dirac-metadata.json#/$defs/"
11-
12-
$schemas:
13-
- "../../schemas/dirac-metadata.json"
14-
159
hints:
1610
$import: "type_dependencies/transformation/metadata-pi_simulate.yaml"
1711

test/workflows/test_meta/test_meta.cwl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@ $schemas:
1717

1818
hints:
1919
- class: dirac:ExecutionHooksHint
20-
hook_plugin: "QueryBased" # should be overrided by inputs with cwl:override (how?)
20+
# TODO: initial value is "QueryBased" (?):
21+
# it should be overrided by inputs with cwl:override (how?)
22+
# to make the test work, we'll put QueryBasedPlugin for now.
23+
hook_plugin: "QueryBasedPlugin"
2124
configuration:
2225
campaign: PROD5
2326
site: LaPalma

0 commit comments

Comments
 (0)