Skip to content

Commit fbe0a57

Browse files
authored
Merge pull request #156 from aldbr/main_FIX_diracx-web-install-resources
fix: installDiracxWeb resources
2 parents 5b0c52d + c2c12de commit fbe0a57

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

diracx/templates/diracx-web/deployment.yaml

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,12 @@ spec:
119119
value: "/tmp/.cypress"
120120
- name: npm_config_cache
121121
value: "/tmp/.npm"
122-
# RAM usage can be high, so we can set a larger limit if needed
123-
{{- with .Values.diracxWeb.installDiracxWeb.resources }}
122+
# RAM usage can be high, so we set a larger limit
124123
resources:
125-
{{- toYaml . | nindent 12 }}
126-
{{- end }}
124+
requests:
125+
memory: 512Mi
126+
limits:
127+
memory: 1Gi
127128
volumeMounts:
128129
# This volume contains the source code of the cloned diracx-web repository
129130
- mountPath: "/diracx-web"
@@ -148,10 +149,25 @@ spec:
148149
httpGet:
149150
path: /
150151
port: http
152+
timeoutSeconds: 15
153+
periodSeconds: 20
154+
successThreshold: 1
155+
failureThreshold: 3
151156
readinessProbe:
152157
httpGet:
153158
path: /
154159
port: http
160+
timeoutSeconds: 15
161+
periodSeconds: 20
162+
successThreshold: 1
163+
failureThreshold: 3
164+
startupProbe:
165+
httpGet:
166+
path: /
167+
port: http
168+
timeoutSeconds: 5
169+
periodSeconds: 5
170+
failureThreshold: 30
155171

156172
{{- if $nodeDevInstall }}
157173
# Start the node module in development mode

diracx/values.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -182,13 +182,6 @@ diracxWeb:
182182
# -- install specification to pass to npm before launching container
183183
repoURL: ""
184184
branch: ""
185-
# -- resources to use for building the webapp if diracxWeb.repoURL is set
186-
# installDiracxWeb:
187-
# resources:
188-
# requests:
189-
# memory: 512Mi
190-
# limits:
191-
# memory: 1Gi
192185

193186
##########################
194187

0 commit comments

Comments
 (0)