Skip to content

mitre-attack references hardcoded in STIX generation logic #5

Description

@himynamesdave

It appears a lot of the code for object has been copied from ATT&CK repo (which is fine). However, it seems some hardcoded values have been incorrectly copied across, in kill_chain_phases and external_references, e.g.

           "kill_chain_phases": [
                {
                    "kill_chain_name": "mitre-attack",
                    "phase_name": "drive-online-harms"
                }
            ],
            "external_references": [
                {
                    "source_name": "mitre-attack",
                    "url": "https://github.com/DISARMFoundation/DISARM_framework/blob/master/techniques/T0048.004.md",
                    "external_id": "T0048.004"
                }
            ],

Suggestion to replace hardcoded mitre-attack with DISARM

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions