Draft: Implement remove_faces - [opened]

[AntonReiswich]

Merges remove_faces -> main

In the branch Add-functionality-in-particular-for-use-cases, we had the following two functions:

1. TopoDS_Shape remove_faces_from_shape (const TopoDS_Shape & shape, const std::vector<int> & indices_of_faces_to_remove)
2. TopoDS_Shell remove_faces(TopoDS_Shell const& shell, std::vector<TopoDS_Face> const& faces)

Before I even start to code, I would like to discuss our API choices in this case:

I assume that a function of the form
Shape remove_shapes(Shape const& shape, Shape const& shapes_to_remove)
would make more sense. What do you think?

[AntonReiswich]

requested review from @klei_j0

[AntonReiswich]

Thinking one step further, if we want to enable history selection, we might also need an overload of this function, allowing to hand over predicates in the argument.

[AntonReiswich]

In GitLab by @klei_j0 on Feb 21, 2025, 17:33

I think the function taking the predicate would suffice. The other overload could be achieved via

auto x = remove_subshapes(from_shape, is_same(shape_to_be_removed))`

I don't see a big benefit of maintaining a second overload. That being said, I wouldn't be bothered if it was there either.

[AntonReiswich]

marked this merge request as draft

[AntonReiswich]

I see, right, one might use the "identity predicate" is_same for this purpose.

[AntonReiswich]

In GitLab by @klei_j0 on Mar 7, 2025, 06:06

We could think about a conversion operator from Shape to Predicate that just returns is_same(*this)? Then you could pass in a shape and the argument conversion would convert it to the identity predicate.

[AntonReiswich]

I think this is a nice idea.