Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reimplement storage class with hashicorp/kubernetes provider #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: reimplement storage class with hashicorp/kubernetes provider #9

wants to merge 1 commit into from

Conversation

mercuriete
Copy link

@mercuriete mercuriete commented Dec 1, 2021 •
edited
Loading

Fixes #8

Motivation in our internal CICD system the kubectl provider was not working properly and we want to use an official provider for doing that functionality.

It is not a breaking change but It will destroy the storage class and create another one with the same name.
This was tested on my internal EKS cluster and everything worked properly.

Types of changes

What types of changes does your code introduce to <repo_name>?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

@Lillecarl
Copy link
Contributor

Lillecarl commented Feb 3, 2022 •
edited
Loading 

resource "kubernetes_storage_class" "efs-dp" {
  metadata {
    name = "efs-dp"
  }

  storage_provisioner = "efs.csi.aws.com"
  parameters = {
    provisioningMode = "efs-ap" # Access point
    fileSystemId     = module.efs.id
    directoryPerms   = "700"
    # gidRangeStart: "1000" # optional
    # gidRangeEnd: "2000" # optional
    # basePath: "/dynamic_provisioning" # optional
  }
}

This is how i ended up doing our SC for dynamic provisioning, straight out the controller YAML example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxr463 oxr463 oxr463 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reimplement storage class with "kubernetes_storage_class"
3 participants
@mercuriete @Lillecarl @oxr463