Warning of testcases changes is unintentionally triggered after clicking "Retrieve Full Package" in submission page

[2018hahazhufeng]

Description of the problem

In jury's submission details page, if you click the "Retrieve Full Package" button, the following warning will appear:

The problem's testcases have changed since this judging has been performed. We recommend rejudging the whole problem.

Before click the button:

After:

While I did not change anything about the testcases.

Your environment

• DOMjudge 9.0.0

Any other information that you want to share?

I suspect that this issue is caused by the following code, which was intended to check whether new testcases have been added. However, operations such as "Retrieve Full Package" will add debug_info rows to the judgetask table, which affects the query result $judgingRunTestcaseHashesInOrder to be not as expected.

domjudge/webapp/src/Controller/Jury/SubmissionController.php

Lines 427 to 429 in 17ef53d

	if (count($judgingRunTestcaseHashesInOrder) !== count($runResults)) {
	$sameTestcaseHashes = false;
	}