net/mlx5: fix invalid queue index handling

lrw514 · raslandarawsheh · commit 495cd38451b4 · 2025-11-06T14:19:39.000+02:00
When failing to allocate a meter HW resource, PMD may use an invalid index to release the job. Fixes: 4359d9d ("net/mlx5: fix sync meter processing in HWS") Cc: getelson@nvidia.com Cc: stable@dpdk.org Signed-off-by: Rongwei Liu <rongweil@nvidia.com> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -1934,6 +1934,8 @@ flow_hw_meter_mark_compile(struct rte_eth_dev *dev,
 	aso_mtr = flow_hw_meter_mark_alloc(dev, queue, action, job,
 					   true, error);
 	if (!aso_mtr) {
+		if (queue == MLX5_HW_INV_QUEUE)
+			queue = CTRL_QUEUE_ID(priv);
 		flow_hw_job_put(priv, job, queue);
 		return -1;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1934,6 +1934,8 @@ flow_hw_meter_mark_compile(struct rte_eth_dev *dev,`
`1934`	`1934`	`aso_mtr = flow_hw_meter_mark_alloc(dev, queue, action, job,`
`1935`	`1935`	`true, error);`
`1936`	`1936`	`if (!aso_mtr) {`
	`1937`	`+ if (queue == MLX5_HW_INV_QUEUE)`
	`1938`	`+ queue = CTRL_QUEUE_ID(priv);`
`1937`	`1939`	`flow_hw_job_put(priv, job, queue);`
`1938`	`1940`	`return -1;`
`1939`	`1941`	`}`