If speed frr #292
If speed frr #292
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
frr/if_grout.c
Outdated
| const struct gr_iface_info_port *gr_port = NULL; | ||
| ifindex_t link_ifindex = IFINDEX_INTERNAL; | ||
| const struct rte_ether_addr *mac = NULL; | ||
| uint32_t txqlen = 1000; | ||
| uint32_t speed = 0, txqlen = 1000; |
There was a problem hiding this comment.
Variable txqlen is initialized but never used; consider removing it or invoking the appropriate dplane helper to set TX queue length.
frr/if_grout.c
Outdated
| dplane_ctx_set_intf_txqlen(ctx, txqlen); | ||
|
|
||
| if (new) { | ||
| dplane_ctx_set_ifp_speed_set(ctx, true); |
There was a problem hiding this comment.
Calling dplane_ctx_set_ifp_speed_set(ctx, true) unconditionally will disable kernel polling even when gr_port->base.link_speed is unset (UINT32_MAX) and speed remains 0; restrict setting speed_set to the valid‐speed case.
maxime-leroy
force-pushed
the
if_speed_frr
branch
from
c16805e to
1da1a10
Compare
frr/if_grout.c
Outdated
| const struct gr_iface_info_port *gr_port = NULL; | ||
| ifindex_t link_ifindex = IFINDEX_INTERNAL; | ||
| const struct rte_ether_addr *mac = NULL; | ||
| uint32_t txqlen = 1000; | ||
| uint32_t speed = 0, txqlen = 1000; |
There was a problem hiding this comment.
txqlen is declared but never used; either remove it or invoke the appropriate dplane_ctx_set_intf_txqlen(ctx, txqlen) call.
maxime-leroy
force-pushed
the
if_speed_frr
branch
from
1da1a10 to
8ca8850
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use the new dplane setters dplane_ctx_set_ifp_speed() and dplane_ctx_set_ifp_speed_set() to pass interface link speed to zebra. This depends on a not-yet-merged zebra dplane API, so this commit is for local testing only and must not be merged until the upstream API lands. Signed-off-by: Maxime Leroy <[email protected]>
maxime-leroy
force-pushed
the
if_speed_frr
branch
from
8ca8850 to
9e24a62
Compare
1 participant
No description provided.