port: cleanup fslmc bus (not working) #347
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ca9336. Signed-off-by: Maxime Leroy <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maxime-leroy
changed the title
This reverts commit e82a2d4. Signed-off-by: Maxime Leroy <[email protected]>
Like pci bus, we should not probe any devices on fslmc bus. Let's add a fake device in the allowed list of DPDK. Note: This series doesn't work as fslmc bus do nothing to plug or unplug a device. [1]. So it should not be merged until it has been fixed in the DPDK. [1] https://git.dpdk.org/dpdk/tree/drivers/bus/fslmc/fslmc_bus.c#n591 Signed-off-by: Maxime Leroy <[email protected]>
maxime-leroy
force-pushed
the
cleanup_fslmc_not_working
branch
from
58ca315 to
efebe4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be merged until the fslmc bus implement properly the hotplug.