fixing linting errors (#54)

Author: sachin-panayil

agency-indexes/DoE/magpie.json

@@ -1,31 +1,31 @@
 {
     "contact": {
-        "email": "christopher.kowalczyk@inl.gov"
+        "email": "holdensanchez2@llnl.gov"
     },
     "date": {
-        "created": "2018-04-24",
-        "metadataLastUpdated": "2023-03-15"
+        "created": "2018-07-30",
+        "metadataLastUpdated": "2020-02-05"
     },
-    "description": "Mesoscale Atomistic Glue Program for Integrated Execution",
-    "laborHours": 14333.6,
+    "description": "Magpie contains a number of scripts for running Big Data software in HPC environments, including Hadoop and Spark. There is support for Lustre, Slurm, Moab, Torque. and LSF.\n",
+    "laborHours": 52607.2,
     "languages": [],
-    "name": "magpie",
-    "organization": "Idaho National Laboratory (INL)",
+    "name": "Magpie",
+    "organization": "Lawrence Livermore National Laboratory (LLNL)",
     "permissions": {
         "exemptionText": null,
         "licenses": [
             {
-                "URL": "https://api.github.com/licenses/lgpl-2.1",
-                "name": "LGPL-2.1"
+                "URL": "https://api.github.com/licenses/gpl-2.0",
+                "name": "GPL-2.0"
             }
         ],
         "usageType": "openSource"
     },
-    "repositoryURL": "https://github.com/idaholab/magpie",
+    "repositoryURL": "https://github.com/LLNL/magpie",
     "status": "Production",
     "tags": [
         "DOE CODE",
-        "Idaho National Laboratory (INL)"
+        "Lawrence Livermore National Laboratory (LLNL)"
     ],
     "vcs": "git"
 }

assets/_common/js/filters.js

@@ -59,16 +59,18 @@ const applySelectFilters = (data, filters, targetType) => Object.entries(filters
 
                 switch (key) {
                     case 'language':
-                        actualKey = 'languages'
+                        actualKey = 'languages';
                         break;
                     case 'category':
-                        actualKey = 'categories'
+                        actualKey = 'categories';
                         break;
                     case 'platform':
-                        actualKey = 'platforms'
+                        actualKey = 'platforms';
                         break;
                     case 'agency':
-                        actualKey = 'agencyName'
+                        actualKey = 'agencyName';
+                        break;
+                    default:
                         break;
                 }
 
@@ -107,10 +109,15 @@ const sortData = (data, sortBy) => {
                 return 0;
         }
 
+        if (aVal === bVal) {
+            return 0;
+        }
+
         if (direction === 'desc') {
-            return aVal < bVal ? 1 : aVal > bVal ? -1 : 0;
+            return aVal < bVal ? 1 : -1;
         }
-        return aVal > bVal ? 1 : aVal < bVal ? -1 : 0;
+
+        return aVal > bVal ? 1 : -1;
     });
 };
 
@@ -165,7 +172,7 @@ const createProjectCardHTML = (project) => {
         if (Array.isArray(value)) return value;
         if (typeof value === 'string') return [value];
         return [];
-    }
+    };
 
     return `
         <div class="project-card">
@@ -213,7 +220,7 @@ const createCard = (item, targetType) => {
     const cardElement = document.createElement('div');
     cardElement.innerHTML = targetType === 'agencies'
         ? createAgencyCardHTML(item)
-        : createProjectCardHTML(item)
+        : createProjectCardHTML(item);
 
     return cardElement.firstElementChild;
 };
@@ -229,7 +236,7 @@ const updateDisplay = (state) => {
 
     state.filteredData.forEach(item => {
         const card = createCard(item, state.targetType);
-        container.appendChild(card)
+        container.appendChild(card);
     });
 };
 
@@ -353,4 +360,4 @@ document.addEventListener('DOMContentLoaded', () => {
             }
         }
     }
-});
+});

assets/_common/js/issue-filters.js

@@ -81,10 +81,15 @@ const sortData = (data, sortBy) => {
               return 0;
       }
 
+      if (aVal === bVal) {
+          return 0;
+      }
+
       if (direction === 'desc') {
-          return aVal < bVal ? 1 : aVal > bVal ? -1 : 0;
+          return aVal < bVal ? 1 : -1;
       }
-      return aVal > bVal ? 1 : aVal < bVal ? -1 : 0;
+
+      return aVal > bVal ? 1 : -1;
   });
 };
 
@@ -159,7 +164,7 @@ const createIssueCardHTML = (issue) => {
   `;
 };
 
-const createCard = (item, targetType) => {
+const createCard = (item) => {
   const cardElement = document.createElement('div');
   cardElement.innerHTML = createIssueCardHTML(item);
   return cardElement.firstElementChild;
@@ -176,7 +181,7 @@ const updateDisplay = (state) => {
 
   container.innerHTML = '';
   state.filteredData.forEach(item => {
-      const card = createCard(item, state.targetType);
+      const card = createCard(item);
       container.appendChild(card);
   });
 };
@@ -342,4 +347,4 @@ document.addEventListener('DOMContentLoaded', () => {
           }
       }
   }
-});
+});

config/updateCodeGov.js

@@ -19,25 +19,38 @@ async function updateCodeGov() {
 
     // read all files in the directory
     const filenames = await fs.readdir(CONFIG.agencyDirectory)
-    
-    // we know that the directory will only contain json files so dont need to check for non jsons
-    for (const file of filenames) {
-      const filePath = path.join(CONFIG.agencyDirectory, file)
-      
-      try {
-        const content = await fs.readFile(filePath, 'utf-8')
-        const jsonData = JSON.parse(content)
-        
-        // store the agency name only for readability in codegov.json 
-        const matches = file.match(CONFIG.regex)
-        const agencyName = matches[1]
 
+    const processedFiles = await Promise.all(
+      filenames.map(async (file) => {
+        const filePath = path.join(CONFIG.agencyDirectory, file)
+
+        try {
+          const content = await fs.readFile(filePath, 'utf-8')
+          const jsonData = JSON.parse(content)
+
+          // store the agency name only for readability in codegov.json
+          const matches = file.match(CONFIG.regex)
+          const agencyName = matches ? matches[1] : null
+
+          if (!agencyName) {
+            return null
+          }
+
+          console.log(`✅ Successfully processed: ${file}`)
+          return [agencyName, jsonData]
+        } catch (error) {
+          console.error(`❌ Error processing file: ${file}`, error)
+          return null
+        }
+      })
+    )
+
+    processedFiles.forEach((entry) => {
+      if (entry) {
+        const [agencyName, jsonData] = entry
         updatedJSON[agencyName] = jsonData
-        console.log(`✅ Successfully processed: ${file}`)
-      } catch (error) {
-        console.error(`❌ Error processing file: ${file}`, error)
       }
-    }
+    })
 
     // actually update the codegov.json file
     const jsonString = JSON.stringify(updatedJSON, null, 2)
@@ -46,7 +59,8 @@ async function updateCodeGov() {
     return updatedJSON
   } catch (error) {
     console.error('❌ Failed to update codegov.json:', error)
+    return null
   }
 }
 
-updateCodeGov()
+updateCodeGov()