fixup(ews): drop unused Context import + dead summary_view, collapse

            duplicate connection-check arms, rustfmt

Cargo.lock is updated by Cargo's first compile after a fresh dependency
add (async-trait); committing it so a clean checkout doesn't churn it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Arthur Perrot

src/commands/source.rs

@@ -101,10 +101,7 @@ pub async fn run(pool: &SqlitePool, key: &[u8; 32], cmd: SourceCommands) -> Resu
         } => {
             let provider = provider.trim().to_ascii_lowercase();
             if provider != factory::kinds::CALDAV && provider != factory::kinds::EWS {
-                bail!(
-                    "unknown provider '{}'. Use 'caldav' or 'ews'.",
-                    provider
-                );
+                bail!("unknown provider '{}'. Use 'caldav' or 'ews'.", provider);
             }
 
             let account: (String,) = sqlx::query_as("SELECT id FROM accounts LIMIT 1")
@@ -125,7 +122,10 @@ pub async fn run(pool: &SqlitePool, key: &[u8; 32], cmd: SourceCommands) -> Resu
                         let email_for_disco = email
                             .clone()
                             .unwrap_or_else(|| prompt("Email (for Autodiscover)"));
-                        print!("{} Discovering EWS endpoint via Autodiscover… ", "…".dimmed());
+                        print!(
+                            "{} Discovering EWS endpoint via Autodiscover… ",
+                            "…".dimmed()
+                        );
                         io::stdout().flush().ok();
                         match crate::ews::autodiscover::discover_ews_url(
                             &email_for_disco,

src/ews/ical.rs

@@ -76,11 +76,7 @@ pub fn synth_vcalendar(item: &EwsCalendarItem) -> Option<String> {
 fn format_dt(value: &str, all_day: bool) -> String {
     if all_day {
         // All-day events use VALUE=DATE with YYYYMMDD.
-        let date = value
-            .chars()
-            .take(10)
-            .collect::<String>()
-            .replace('-', "");
+        let date = value.chars().take(10).collect::<String>().replace('-', "");
         return format!(";VALUE=DATE:{}", date);
     }
     // EWS UTC is YYYY-MM-DDTHH:MM:SSZ → iCal UTC YYYYMMDDTHHMMSSZ.

src/ews/mod.rs

@@ -119,11 +119,7 @@ impl CalendarProvider for EwsProvider {
         Ok(synth_or_fetch_mime(self, items).await)
     }
 
-    async fn sync_delta(
-        &self,
-        calendar_id: &str,
-        sync_state: Option<&str>,
-    ) -> Result<DeltaResult> {
+    async fn sync_delta(&self, calendar_id: &str, sync_state: Option<&str>) -> Result<DeltaResult> {
         // Cursor-seeding mode (see trait docs): the caller has already
         // populated the local cache via `fetch_events` and only wants a
         // starting cursor. EWS's `SyncFolderItems` without a state walks
@@ -196,13 +192,9 @@ impl CalendarProvider for EwsProvider {
         .await
         .unwrap_or_default();
         for item_id in &existing {
-            if let Err(e) = operations::delete_item(
-                &self.endpoint,
-                &self.username,
-                &self.password,
-                item_id,
-            )
-            .await
+            if let Err(e) =
+                operations::delete_item(&self.endpoint, &self.username, &self.password, item_id)
+                    .await
             {
                 tracing::warn!(uid = %uid, error = %e, "EWS could not delete prior copy before re-create; continuing");
             }

src/ews/operations.rs

@@ -29,13 +29,12 @@ pub async fn check_connection(endpoint: &str, username: &str, password: &str) ->
     </m:GetFolder>
 "#;
     let resp = post_soap(endpoint, username, password, body, false).await?;
-    if resp.contains("FolderId") {
-        Ok(true)
-    } else if resp.contains("ResponseClass=\"Success\"") {
+    // post_soap already raises on SOAP faults; we only need to confirm the
+    // response carries a real folder reference (or, as a softer fallback, the
+    // standard Success class) before declaring the endpoint EWS-compatible.
+    if resp.contains("FolderId") || resp.contains("ResponseClass=\"Success\"") {
         Ok(true)
     } else {
-        // post_soap already raises on faults; this branch only hits when the
-        // server replied 200 but with an unexpected body shape.
         bail!("EWS GetFolder returned no FolderId — server may not be EWS-compatible")
     }
 }
@@ -119,7 +118,6 @@ async fn list_items_window(
 ) -> Result<Vec<EwsCalendarItem>> {
     let mut all = Vec::new();
     let mut offset: u32 = 0;
-    let mut summary_view = String::new();
     loop {
         let view = if let (Some(s), Some(e)) = (start_utc, end_utc) {
             // CalendarView expands recurrences; no offset paging is needed
@@ -134,7 +132,6 @@ async fn list_items_window(
                 r#"<m:IndexedPageItemView MaxEntriesReturned="{PAGE_SIZE}" Offset="{offset}" BasePoint="Beginning" />"#,
             )
         };
-        summary_view = view.clone();
 
         let body = format!(
             r#"    <m:FindItem Traversal="Shallow">
@@ -183,7 +180,7 @@ async fn list_items_window(
             break;
         }
     }
-    tracing::debug!(folder = %folder_id, count = all.len(), view = %summary_view, "EWS FindItem complete");
+    tracing::debug!(folder = %folder_id, count = all.len(), "EWS FindItem complete");
     Ok(all)
 }
 

src/ews/parse.rs

@@ -6,7 +6,7 @@
 //! consistent enough that targeted extraction is reliable, and the test
 //! suite (alongside `cargo clippy`) catches regressions.
 
-use anyhow::{bail, Context, Result};
+use anyhow::{bail, Result};
 use base64::Engine;
 
 use super::soap::{attr, collect_blocks, collect_tag_contents, first_tag_content};

src/ews/soap.rs

@@ -72,7 +72,11 @@ pub async fn post_soap(
     body: &str,
     fetch: bool,
 ) -> Result<String> {
-    let timeout = if fetch { FETCH_TIMEOUT } else { DEFAULT_TIMEOUT };
+    let timeout = if fetch {
+        FETCH_TIMEOUT
+    } else {
+        DEFAULT_TIMEOUT
+    };
     let client = http_client(timeout)?;
     let envelope = envelope(body);
 
@@ -114,8 +118,8 @@ pub fn extract_soap_fault(xml: &str) -> Option<String> {
         return None;
     }
     // Errors come either as a SOAP Fault or as a per-message ResponseCode.
-    if let Some(reason) = first_tag_content(xml, "faultstring")
-        .or_else(|| first_tag_content(xml, "Reason"))
+    if let Some(reason) =
+        first_tag_content(xml, "faultstring").or_else(|| first_tag_content(xml, "Reason"))
     {
         return Some(reason);
     }
@@ -337,10 +341,7 @@ mod tests {
     #[test]
     fn fault_detection() {
         let xml = "<soap:Fault><faultstring>auth required</faultstring></soap:Fault>";
-        assert_eq!(
-            extract_soap_fault(xml),
-            Some("auth required".to_string())
-        );
+        assert_eq!(extract_soap_fault(xml), Some("auth required".to_string()));
     }
 
     #[test]

src/providers/caldav.rs

@@ -78,11 +78,7 @@ impl CalendarProvider for CaldavProvider {
             .collect())
     }
 
-    async fn sync_delta(
-        &self,
-        calendar_id: &str,
-        sync_state: Option<&str>,
-    ) -> Result<DeltaResult> {
+    async fn sync_delta(&self, calendar_id: &str, sync_state: Option<&str>) -> Result<DeltaResult> {
         let result = self.client.sync_collection(calendar_id, sync_state).await?;
         // CalDAV reports deletions as 404 hrefs. The href ends with `{uid}.ics`,
         // so we extract the UID — the rest of calrs keys events by UID.

src/providers/mod.rs

@@ -88,11 +88,7 @@ pub trait CalendarProvider: Send + Sync {
     /// items. Implementations may therefore return an empty
     /// `added_or_changed` when `sync_state` is `None` — the caller has
     /// already populated the local cache through `fetch_events`.
-    async fn sync_delta(
-        &self,
-        calendar_id: &str,
-        sync_state: Option<&str>,
-    ) -> Result<DeltaResult>;
+    async fn sync_delta(&self, calendar_id: &str, sync_state: Option<&str>) -> Result<DeltaResult>;
 
     /// Create-or-replace an event. `uid` is the iCalendar UID, `ics` is the
     /// full VCALENDAR/VEVENT block.