Non optional fields are not declared as "not null" in postgres

[motey]

via @Lauchzwiebel
e.g.
Death.person_id is a requiered field https://ohdsi.github.io/CommonDataModel/cdm54.html#death

Note

The same field in the actual dzd-omop-cdm-python-model: https://github.com/DZD-eV-Diabetes-Research/dzd-omop-cdm-python-models/blob/main/DZDOMOPModel/omopmodel/OMOP_5_4_sqlmodels.py#L861

We would expect that this will result in a not null field in the data scheme in a postgres db. but actual it is not

Lets find out why is that and if its a bug.

[motey]

Sorry, I can not confirm this behavior.
Steps i tried to reproduce

Started a fresh postgres db with docker compose

docker-compose.yaml

services:
  postgres:
    image: docker.io/library/postgres:12-alpine
    restart: no
    ports:
      - 5432:5432
    environment:
      - POSTGRES_PASSWORD=ps
      - POSTGRES_USER=ps
      - POSTGRES_DB=ps

docker compose up -d

Prepared Python env with

python -m pip install dzdomop -U

Ran following script

test.py

from sqlalchemy import create_engine
from omopmodel import OMOP_5_4_declarative as omop54
from omopmodel import VocabulariesLoader

# Define the connection to our running postgresql database
engine = create_engine("postgresql+pg8000://ps:ps@localhost/ps")

# Create the OMOP Schema on our database
omop54.Base.metadata.create_all(engine)

python test.py

Result

Death table with person_id and death_date declared as NOT NULL