Skip to content

Commit 08df054

Browse files
authored
Improved Default Params (#3)
After testing these parameters seem to work better than the previous defaults for modern lidars (e.g. OS1).
1 parent 6568e2a commit 08df054

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

loam/include/loam/features.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,32 +37,32 @@ namespace loam {
3737
struct FeatureExtractionParams {
3838
/// @brief The number of neighbor points (on either size) to use when computing curvature [1] Eq. (1)
3939
/// A reasonable number is between 3 and 6, less and curvature is too noisy, more and points cover too large an area
40-
size_t neighbor_points{5};
40+
size_t neighbor_points{3};
4141
/// @brief The number of sectors to break each scan line into when detecting feature points
4242
/// A reasonable number is between 4 and 8
4343
// If the number of points per line is not divisible by number_sectors, remainder points are added to the last sector
4444
size_t number_sectors{6};
4545
/// @brief The maximum number of edge features to detect in each sector
4646
/// Reasonable numbers depends on compute power available for registration, with more points registration is expensive
47-
size_t max_edge_feats_per_sector{5};
47+
size_t max_edge_feats_per_sector{10};
4848
/// @brief The maximum number of planar features to detect in each sector
4949
/// Reasonable numbers depends on compute power available for registration, with more points registration is expensive
50-
size_t max_planar_feats_per_sector{5};
50+
size_t max_planar_feats_per_sector{50};
5151
/// @brief Threshold for edge feature curvature.
5252
/// The UNNORMALIZED curvature must be greater than this thresh to be considered an edge feature.
5353
/// WARN: This is an unintuitive param manual tuning and plotting results is recommended
5454
double edge_feat_threshold{100.0};
5555
/// @brief Threshold for planar feature curvature.
5656
/// The UNNORMALIZED curvature must be less than this thresh to be considered a planar feature.
5757
/// WARN: This is an unintuitive param manual tuning and plotting results is recommended
58-
double planar_feat_threshold{0.1};
58+
double planar_feat_threshold{1.0};
5959
/// @brief This distance in point units (e.x. meters) between neighboring points to be considered for occlusion
6060
/// Reasonable values are on the order of 1m for most robotics applications
61-
double occlusion_thresh{0.25};
61+
double occlusion_thresh{0.5};
6262
/// @brief The range difference (as proportion of range) between consecutive points to be considered too parallel
6363
/// See computeValidPoints::Check 4 for details
6464
/// WARN: This is an unintuitive param manual tuning and plotting results is recommended
65-
double parallel_thresh{0.002};
65+
double parallel_thresh{1.0};
6666
};
6767

6868
/// @brief Structure for storing edge and planar feature points from a scan together

0 commit comments

Comments
 (0)