Anti Malware list has malformed comments

[swills1]

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

Hello,

I’m writing regarding the following file:

http://github.com/DandelionSprout/adfilt/blob/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareHosts.txt

In the top comment section, line 8 currently contains:

!#if !env_mv3

Because this line begins with !, it makes standardization more difficult when processing or merging with other lists, as most lists conventionally use # for comments. Filtering or omitting lines starting with ! can therefore introduce inconsistencies during normalization.

I assume this directive may have been generated automatically.

This is not a major issue, but adjusting the comment style (or clarifying the intended syntax) would make it easier to standardize this list alongside others. (For now we can just check for special characters that domain cannot contain - but some people may not have that logic built into their workflow.)

Thank you for your work maintaining the project.

Add screenshots below (Required, except for Anti-Malware List. Claiming the problem is obvious does not count.)

No response

Add a screenshot of the extension's logger

No response

Which adblocker(s) did you use when testing this?

(Other)

Adblocker version(s)

No response

Which filterlists did you use? Failing to tell this with at least 10 letters or 1 image, will close the report until it has been told.

https://github.com/DandelionSprout/adfilt/blob/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareHosts.txt

Which browser(s) did you use when testing this?

(Other)

Browser version(s)

No response

Which OS(s) did you use when testing this?

(Other)

OS version(s)

NA

[iam-py-test]

This seems to be a deliberate decision by Dandelion Sprout:

adfilt/NorwegianExperimentalList alternate versions/XYZPrepareFilters.py

Line 6344 in 91f9a0d

r"\1\n# Users of Pi-Hole FTL 5.22 and later can consider switching to the || version at https://raw.githubusercontent.com/DandelionSprout/adfilt/refs/heads/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareAdGuardHome.txt, due to an unconfirmed belief of mine that it allows better wildcarding than the Hosts and raw-domains versions.\n# Users of uBlock Origin are STRONGLY RECOMMENDED to switch to the uBO list version at https://raw.githubusercontent.com/DandelionSprout/adfilt/refs/heads/master/Dandelion%20Sprout's%20Anti-Malware%20List.txt, unless otherwise proven.\n# Users of AdGuard Home are STRONGLY RECOMMENDED to switch to the || version at https://raw.githubusercontent.com/DandelionSprout/adfilt/refs/heads/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareAdGuardHome.txt, unless otherwise proven.\n!#if !env_mv3",

The same line is added to several other versions.
This is a pre-parsing directive for uBlock Origin and maybe AdGuard which completely disables the list if loaded in an MV3 extension.
As such, I will leave it up to Dandelion Sprout to address this.
Thank you

[swills1]

Ah, no that make sense. It isn't a blocker. Please close.

[iam-py-test]

This still might cause issues with some content blockers which don't understand the syntax. I just don't want to change anything without his permission as this is intentional.

[DandelionSprout]

For various reasons I'm inclined to let that line stay, as I am indeed pretty hostile to MV3.

There is however one possibility that comes to my mind: If anyone can find decisive proof that uBO Lite is unable to load the Hosts file as a custom list, I'd consider it much more to remove that line.

[iam-py-test]

uBO Lite doesn't support custom lists.

[DandelionSprout]

Good to know. I'll take a look into it sometime tomorrow (Monday).

[iam-py-test]

If I recall correctly, gorhill doesn't intend to ever add the ability to add custom filterlists.

The choice of being entirely declarative for the sake of reliability and efficiency meant sacrificing being able to import filter lists

https://github.com/uBlockOrigin/uBOL-home/wiki/Frequently-asked-questions-(FAQ)

I think AdGuard's MV3 extension does support custom filterlists, though I have never used it and might be wrong. I do not know if it supports HOSTs lists.

[DandelionSprout]

AdGuard's browser extensions have long been known to be unable to handle Hosts files; and worse yet, completely and amazingly fail at correctly handling raw domains, for that matter.

[krystian3w]

If I recall correctly, gorhill doesn't intend to ever add the ability to add custom filterlists.

The choice of being entirely declarative for the sake of reliability and efficiency meant sacrificing being able to import filter lists

Wiki: Frequently asked questions (FAQ) (uBlockOrigin/uBOL-home)

I think it is possible that someone at home may be compiling their own lists.

In that case, it is better to leave the if statement so that someone has to make a copy of the list without if statements deliberately.

[swills1]

I don't know if this helps, but I'm using this list at my resolver level. So I can just programmatically strip out the un-needed lines before generating my config(s).

I would think anyone using this list in a custom capacity can do the same.