address review comments on DPC conventions alignment

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Dans-Plugins/Currencies/sessions/5694b649-0f2d-484a-acab-b70b9dcddf20

Author: Copilot

.github/copilot-instructions.md

@@ -14,16 +14,17 @@ making any changes.
 ## Project Structure
 
 - `src/main/kotlin/` – Plugin source code
-- `src/main/resources/` – `plugin.yml`, `config.yml`, and `lang/` files
+- `src/main/resources/` – `plugin.yml`, `config.yml`, and other resource files
 - `src/test/kotlin/` – Unit tests
 - `.github/workflows/` – CI and release workflows
 
 ## Coding Conventions
 
-- Use the `lang/` resource files for every user-facing string; never hard-code
-  messages in Kotlin.
+- Prefer using `lang/` resource files for user-facing strings. When introducing new
+  messages, avoid hard-coding them in Kotlin where a suitable `lang/` resource
+  structure already exists in this project.
 - Follow the existing package structure when adding new classes.
-- Annotate every command executor and event listener with `@Override` where applicable.
+- In Kotlin, use the `override` keyword for overridden members, and annotate Bukkit event listener methods with `@EventHandler`.
 - This plugin depends on Medieval Factions; use its API where faction data is needed.
 
 ## Contribution Workflow

.github/workflows/release.yml

@@ -29,4 +29,4 @@ jobs:
       - name: Upload JAR to release
         uses: softprops/action-gh-release@v2
         with:
-          files: build/libs/*.jar
+          files: build/libs/*-all.jar

COMMANDS.md

@@ -23,7 +23,7 @@
 ### /currency info \<currency\>
 
 **Description:** View information about a specific currency.
-**Permission:** `currencies.list`
+**Permission:** None (available to all players)
 **Usage:** `/currency info <currency>`
 **Example:** `/currency info GoldCoin`
 
@@ -47,9 +47,19 @@
 
 ---
 
+### /currency set name \<currency\> \<new-name\>
+
+**Description:** Set the name of an existing currency. Requires the appropriate faction permission or `currencies.force.rename`.
+**Aliases:** `/currency rename <currency> <new-name>`
+**Permission:** `currencies.rename`
+**Usage:** `/currency set name <currency> <new-name>`
+**Example:** `/currency set name GoldCoin SilverCoin`
+
+---
+
 ### /currency rename \<currency\> \<new-name\>
 
-**Description:** Rename an existing currency. Requires the appropriate faction permission or `currencies.force.rename`.
+**Description:** Alias for `/currency set name`. Rename an existing currency. Requires the appropriate faction permission or `currencies.force.rename`.
 **Permission:** `currencies.rename`
 **Usage:** `/currency rename <currency> <new-name>`
 **Example:** `/currency rename GoldCoin SilverCoin`
@@ -59,6 +69,7 @@
 ### /currency set description \<currency\> \<description\>
 
 **Description:** Set or update the description of a currency. Requires the appropriate faction permission or `currencies.force.desc`.
+**Aliases:** `/currency set desc <currency> <description>`
 **Permission:** `currencies.desc`
 **Usage:** `/currency set description <currency> <description>`
 **Example:** `/currency set description GoldCoin "The official coin of the Northern Kingdom"`

CONTRIBUTING.md

@@ -49,7 +49,7 @@ Issues are grouped into [milestones](https://github.com/Dans-Plugins/Currencies/
 
 ### Language Files
 
-Update `src/main/resources/lang/` for any user-facing string changes.
+For any user-facing string changes, update the appropriate resource files under `src/main/resources/` (for example, `plugin.yml` or `config.yml`). If you add a new localization or language file structure, document it in your pull request.
 
 ## Testing
 
@@ -58,9 +58,13 @@ Run the unit tests with:
 Linux: `./gradlew clean test`
 Windows: `.\gradlew.bat clean test`
 
-For manual testing, start a local Spigot server:
+For manual testing, start a local Spigot server using the helper script:
 
-    docker compose up
+    ./up.sh
+
+To stop the local Spigot server when you're done testing:
+
+    ./down.sh
 
 ## Questions
 

README.md

@@ -99,14 +99,6 @@ You are free to use, modify, and distribute this software, provided that:
 
 See the [LICENSE](LICENSE) file for the full text of the GPL-3.0 license.
 
-## Project Status
-
-This project is in active development.
-
-### bStats
-
-You can view the bStats page for the plugin [here](https://bstats.org/plugin/bukkit/Currencies/12810).
-
 ## Roadmap
 
 - [Known Bugs](https://github.com/Dans-Plugins/Currencies/issues?q=is%3Aopen+is%3Aissue+label%3Abug)
@@ -116,3 +108,11 @@ You can view the bStats page for the plugin [here](https://bstats.org/plugin/buk
 ## Changelog
 
 - [CHANGELOG.md](CHANGELOG.md)
+
+## Project Status
+
+This project is in active development.
+
+### bStats
+
+You can view the bStats page for the plugin [here](https://bstats.org/plugin/bukkit/Currencies/12810).