Skip to content

Commit 50d41bf

Browse files
Address review comments: fix permission message, return true on all handled cases
Agent-Logs-Url: https://github.com/Dans-Plugins/Medieval-Roleplay-Engine/sessions/fd5e1444-ccf9-4a0e-baec-666c47cf5636 Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
1 parent 62f4e15 commit 50d41bf

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/main/java/dansplugins/rpsystem/commands/roll/RollCommand.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ public boolean rollDice(CommandSender sender, String[] args) {
2323
Player player = (Player) sender;
2424

2525
if (!(player.hasPermission("rp.roll") || player.hasPermission("rp.dice") || player.hasPermission("rp.default"))) {
26-
player.sendMessage(medievalRoleplayEngine.colorChecker.getNegativeAlertColor() + "Sorry! In order to use this command, you need one of the following permissions: 'rp.roll', 'rp.dice'");
27-
return false;
26+
player.sendMessage(medievalRoleplayEngine.colorChecker.getNegativeAlertColor() + "Sorry! In order to use this command, you need one of the following permissions: 'rp.roll', 'rp.dice', 'rp.default'");
27+
return true;
2828
}
2929

3030
int max = DEFAULT_DIE_SIZE;
@@ -33,11 +33,11 @@ public boolean rollDice(CommandSender sender, String[] args) {
3333
max = Integer.parseInt(args[0]);
3434
if (max < 1) {
3535
player.sendMessage(medievalRoleplayEngine.colorChecker.getNegativeAlertColor() + "Please provide a positive number to roll.");
36-
return false;
36+
return true;
3737
}
3838
} catch (NumberFormatException e) {
39-
player.sendMessage(medievalRoleplayEngine.colorChecker.getNegativeAlertColor() + "'" + args[0] + "' is not a valid number. Usage: /roll [max]");
40-
return false;
39+
player.sendMessage(medievalRoleplayEngine.colorChecker.getNegativeAlertColor() + "'" + args[0] + "' is not a valid number.");
40+
return true;
4141
}
4242
}
4343

0 commit comments

Comments
 (0)