Skip to content

e2e Linux tests using static binary artifact #196

@Dargon789

Description

@Dargon789

Reviewer's Guide

Modernizes and expands the CI/release pipeline (GitHub Actions and CircleCI), bumps Rust and package versioning, adjusts supported versions and changelog entries, and makes a small runtime PATH update in env handling.

Sequence diagram for e2e Linux tests using static binary artifact

sequenceDiagram
  participant GitHub_Trigger
  participant build_static_linux_binary
  participant Artifact_Store
  participant e2e_linux
  participant Node_Pnpm_Env
  participant Shells

  GitHub_Trigger->>build_static_linux_binary: Start job (ubuntu-latest)
  build_static_linux_binary->>build_static_linux_binary: Checkout code
  build_static_linux_binary->>build_static_linux_binary: Setup Rust 1_88 with musl target
  build_static_linux_binary->>build_static_linux_binary: Install musl-tools
  build_static_linux_binary->>build_static_linux_binary: cargo build --release --target x86_64-unknown-linux-musl
  build_static_linux_binary->>build_static_linux_binary: strip binary
  build_static_linux_binary->>Artifact_Store: Upload fnm-linux artifact

  GitHub_Trigger->>e2e_linux: Start job (needs build_static_linux_binary)
  e2e_linux->>Artifact_Store: Download fnm-linux artifact to target/release
  e2e_linux->>Shells: Install fish zsh bash
  e2e_linux->>e2e_linux: chmod +x target/release/fnm
  e2e_linux->>Node_Pnpm_Env: Setup Node 18_x with pnpm and cache
  e2e_linux->>Node_Pnpm_Env: pnpm install
  e2e_linux->>Node_Pnpm_Env: pnpm test with FNM_TARGET_NAME=release
Loading

File-Level Changes

Change Details Files
Replace legacy GitHub Actions setup with a full Rust CI + multi-platform build/release and e2e pipeline, all targeting Rust 1.88 and current action versions.
  • Bump RUST_VERSION environment from 1.78 to 1.88.
  • Remove the old post_token job and uncomment/reintroduce fmt, clippy, unit_tests, and release build jobs using actions/checkout@v4, hecrj/setup-rust-action@v2, and Swatinem/rust-cache@v2.
  • Add Windows, macOS (universal x86_64 + arm64 via lipo), and Linux static builds with artifact upload using actions/upload-artifact@v4.
  • Introduce e2e_macos, e2e_windows, and e2e_linux jobs that consume built artifacts and run pnpm-based tests with updated pnpm/action-setup and actions/setup-node v4 and cache v4.
  • Add build_static_arm_binary job using QEMU, cross, and run-on-arch for ARM sanity tests.
  • Add ensure_commands_markdown_is_up_to_date job that installs the built Linux binary and runs generate-command-docs in check mode.
.github/workflows/rust.yml
Align release workflow triggers and Node setup with the project’s main branch and supported Node versions.
  • Restrict release workflow to push events on the main branch only.
  • Change actions/setup-node in release.yml to install and cache Node 18.x, 20.x, 22.x, and 24.x instead of a single version 20.
.github/workflows/release.yml
Update documentation to reflect current security support and changelog for version 1.39.1.
  • Replace generic SECURITY.md template text with explicit support matrix for versions 5.1.x, 5.0.x, 4.0.x, and <4.0.
  • Update SECURITY.md vulnerability reporting section back to template-style guidance (likely placeholder).
  • Add 1.39.1 entry to CHANGELOG.md including three patch changes with their PR and commit references.
  • Fix wording in the 1.39.0 changelog line about fnm default (remove superfluous "to").
SECURITY.md
CHANGELOG.md
Clean up CircleCI sample config formatting without changing behavior.
  • Normalize comment spacing and remove trailing whitespace in .circleci/config.yml while keeping the say-hello workflow behavior unchanged.
.circleci/config.yml
Simplify PATH mutation in multishell env setup by removing unnecessary unsafe block.
  • Replace unsafe std::env::set_var("PATH", ...) call with a direct set_var call after join_paths succeeds.
src/commands/env.rs
Bump project and dependency metadata to reflect new release.
  • Update package.json version from 1.39.0 to 1.39.1.
  • Refresh lockfiles (.changeset/config.json, Cargo.lock, site/pnpm-lock.yaml) to align with the new version and dependency graph.
package.json
.changeset/config.json
Cargo.lock
site/pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Originally posted by @sourcery-ai[bot] in #195 (comment)

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdependenciesPull requests that update a dependency filedocumentationImprovements or additions to documentationduplicateThis issue or pull request already existsenhancementNew feature or requestgithub_actionsPull requests that update GitHub Actions codegood first issueGood for newcomershelp wantedExtra attention is neededinvalidThis doesn't seem rightjavascriptPull requests that update javascript codequestionFurther information is requestedrustPull requests that update Rust codewontfixThis will not be worked on

Projects

Status

Backlog

Status

Todo

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions