-
-
Notifications
You must be signed in to change notification settings - Fork 6
batch_priority's documented coverage-target semantic is not implemented #816
Copy link
Copy link
Open
Labels
priority:lowLow urgency; park until higher priorities clearLow urgency; park until higher priorities cleartype:questionOpen architectural or operational question requiring governor decision. Closed when decided.Open architectural or operational question requiring governor decision. Closed when decided.type:taskSingle executable unit of work. One session, one outcome. The default for most issues.Single executable unit of work. One session, one outcome. The default for most issues.
Description
Metadata
Metadata
Assignees
Labels
priority:lowLow urgency; park until higher priorities clearLow urgency; park until higher priorities cleartype:questionOpen architectural or operational question requiring governor decision. Closed when decided.Open architectural or operational question requiring governor decision. Closed when decided.type:taskSingle executable unit of work. One session, one outcome. The default for most issues.Single executable unit of work. One session, one outcome. The default for most issues.
What
POST /v1/coverage/generate:batch'spriorityfield is documented (coverage_routes.py, ADR-057 D1) as:priority ∈ {'high', 'all'}— "'high' raises the target [coverage percentage]". This has never actually been implemented, in either the current pipeline or its predecessor.Verified
will/self_healing/symbol_coverage_remediation.py::remediate_batch_by_symbol()has notarget_coverage/priority-sensitive parameter at all — candidate selection uses a single fixed threshold (_CFG.batch_remediation_threshold_pct) regardless ofbatch_priority.coverage_remediation_service.py::remediate_coverage_enhanced()computed atarget_coveragevalue frombatch_prioritybut never passed it intoBatchRemediationService.process_batch()— it was only used in a log line.So this is pre-existing drift between the documented API contract and the implementation, not something #814 introduced or regressed. Surfaced during #814's implementation and follow-up review (2026-07-18); flagged rather than silently fixed since it needs its own scoped design (what should "high" actually change — a lower/more aggressive coverage threshold? a different candidate count? something else?) and its own tests.
Where
src/api/v1/coverage_routes.py— documents the contractsrc/will/governance/coverage_runner.py::run_and_persist_coverage_batch— accepts and persistsbatch_priorityon the run row but doesn't act on itsrc/will/self_healing/symbol_coverage_remediation.py::remediate_batch_by_symbol— candidate selection entry point that would need to consume it