Modifications

[aducom]

I was not able to make a pull request. This library works fine, only I was not able to retrieve the image as a base64 string, so I made some modifications. For anyone needing this.

    $img= QRcode::png('PHP QR Code :)','*');  

If you use '*' as the filename the function will return a base64 string that you can use in your application:

   $r='<img width="500" src="data:image/png;base64,'.$img.'"/>';             

Required changes are in qrimage

    //----------------------------------------------------------------------
    public static function png($frame, $filename = false, $pixelPerPoint = 4, $outerFrame = 4,$saveandprint=FALSE) 
    {
        $image = self::image($frame, $pixelPerPoint, $outerFrame);
        $r='';
        if ($filename === false) {
            Header("Content-type: image/png");
            ImagePng($image);
        } else {
            if($saveandprint===TRUE){
                ImagePng($image, $filename);
                header("Content-type: image/png");
                ImagePng($image);
            }else{
                if($filename=='*') {
                   ob_start();
                   ImagePng($image);
                   $r = base64_encode(ob_get_contents());
                   ob_end_clean();
                } else { 
                   ImagePng($image, $filename);
                } 
            }
        }
        
        ImageDestroy($image);
        return $r;
    }

in qrencode

   //----------------------------------------------------------------------
    public function encodePNG($intext, $outfile = false,$saveandprint=false) 
    {
        try {
        
            ob_start();
            $tab = $this->encode($intext);
            $err = ob_get_contents();
            ob_end_clean();
            
            if ($err != '')
                QRtools::log($outfile, $err);
            
            $maxSize = (int)(QR_PNG_MAXIMUM_SIZE / (count($tab)+2*$this->margin));
            
            return QRimage::png($tab, $outfile, min(max(1, $this->size), $maxSize), $this->margin,$saveandprint);
        
        } catch (Exception $e) {
        
            QRtools::log($outfile, $e->getMessage());
        
        }
    }
}

[RaphaelWimmer]

@aducom Thank you - that was exactly what I needed. For the record: are your suggested changes also licensed under the LGPL3?

[aducom]

As the changes apply to existing code, I think that the license is the same? Not sure how that works.

[Darkflib]

Tbh, the OSS community tends to be hot on blatant infringement, but for 1 or 2 lines it is ignored by most... Or they just add the contribution to the authors file.Worst case the author would need to prove that it was done willfully and that it caused harm/loss.This is harder with 'free' software, but I am not a lawyer, so if it is important to you check with your legal counsel.On 2 Mar 2023 10:23, Albert Drent ***@***.***> wrote: As the changes apply to existing code, I think that the license is the same? Not sure how that works. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[aducom]

I made changes to the component to have it work for me. As part of the license, I published my changes. I do not own the component and don't think my changes would infringe on any license. I propose the change for the author as I could not make a pull request. It is up to the author to adopt or not.

[RaphaelWimmer]

Thanks for clarifying this, @aducom . Just for the record: as far as you are concerned, you are releasing your modifications under the same license as the original code (LGPL v3), right?

(Sorry for pestering you with this question - I just want to make sure that I and others can actually use your modifications)

[aducom]

As far as I know, when you apply changes to an open-source package, you cannot change the license conditions. I made very minor changes, so for me, the original license apply. If I had a choice I would change it to Mit.