Fix dashboards ready check in cypress workflow

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>

Author: DarshitChanpura

.github/workflows/cypress-test-resource-sharing-enabled-e2e.yml

@@ -100,24 +100,35 @@ jobs:
         run: |
           nohup yarn start --no-base-path --no-watch --csp.warnLegacyBrowsers=false | tee dashboard.log &
         shell: bash
+        working-directory: OpenSearch-Dashboards
 
-      # Check if OSD is ready with a max timeout of 600 seconds
-      - name : Check If OpenSearch Dashboards Is Ready
+      # Check if OSD is ready with a max timeout of 60 seconds
+      - name: Wait for OpenSearch Dashboards (status API)
+        shell: bash
+        working-directory: OpenSearch-Dashboards
+        env:
+          OSD_URL: http://localhost:5601
+          OSD_USER: admin
+          OSD_PASS: ${{ env.OPENSEARCH_INITIAL_ADMIN_PASSWORD }}
+          TIMEOUT: "200"   # seconds
+          INTERVAL: "5"    # seconds
         run: |
-          echo "Start checking OpenSearch Dashboards."
-          for i in {1..6}; do
-            if grep -q "http server running" "dashboard.log"; then
-              echo "OpenSearch Dashboards started successfully."
-              break
-            fi
-            if [ $i -eq 6 ]; then
-              echo "Timeout for 60 seconds reached. OpenSearch Dashboards did not start."
-              exit 1
+          set -euo pipefail
+          end=$((SECONDS + TIMEOUT))
+          while (( SECONDS < end )); do
+            # GET /api/status; treat as ready only when it reports 401/302
+            if [ "$code" = "401" ] || [ "$code" = "302" ]; then
+              echo "Server responding (HTTP $code); considering it up."
+              exit 0
             fi
-            sleep 10
+
+            sleep "${INTERVAL}"
           done
-        shell: bash
-        working-directory: OpenSearch-Dashboards
+
+          echo "Timed out after ${TIMEOUT}s waiting for OpenSearch Dashboards status."
+          echo "Last 200 lines of dashboard.log:"; tail -n 200 dashboard.log || true
+          exit 1
+
 
       - name: Run Cypress Tests with retry
         uses: Wandalen/wretry.action@v3.3.0