Skip to content

Commit 72722d1

Browse files
Irozukucristian-tamblay
authored andcommitted
fix: update metric split handling to use effective split in SessionVisualization
1 parent 52f749c commit 72722d1

1 file changed

Lines changed: 18 additions & 3 deletions

File tree

DashAI/front/src/components/models/SessionVisualization.jsx

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,21 @@ export default function SessionVisualization() {
189189
[runs],
190190
);
191191

192+
const availableSplits = React.useMemo(
193+
() =>
194+
[
195+
hasTrainMetrics && "train",
196+
hasValidationMetrics && "validation",
197+
hasTestMetrics && "test",
198+
].filter(Boolean),
199+
[hasTrainMetrics, hasValidationMetrics, hasTestMetrics],
200+
);
201+
202+
const effectiveSplit =
203+
availableSplits.length === 0 || availableSplits.includes(metricSplit)
204+
? metricSplit
205+
: availableSplits[0];
206+
192207
const handleTrainWithTour = (run) => {
193208
if (onTrain) onTrain(run);
194209
if (sessionTourContext?.run && sessionTourContext?.stepIndex === 5) {
@@ -569,7 +584,7 @@ export default function SessionVisualization() {
569584
hasValidationMetrics ||
570585
hasTestMetrics) && (
571586
<PillToggleButtonGroup
572-
value={metricSplit}
587+
value={effectiveSplit}
573588
onChange={(e, newValue) => {
574589
if (newValue !== null) setMetricSplit(newValue);
575590
}}
@@ -615,7 +630,7 @@ export default function SessionVisualization() {
615630
onViewDetails={handleViewDetails}
616631
onDelete={onDeleteRun}
617632
onRowClick={handleRowClick}
618-
metricSplit={metricSplit}
633+
metricSplit={effectiveSplit}
619634
/>
620635

621636
{/* Graphs and statistical tests button toggle just when cross validation is being used */}
@@ -663,7 +678,7 @@ export default function SessionVisualization() {
663678
{view === "graphs" ? (
664679
<ResultsGraphs
665680
runs={runs}
666-
selectedSplit={metricSplit}
681+
selectedSplit={effectiveSplit}
667682
onSplitChange={setMetricSplit}
668683
metrics={allMetrics}
669684
/>

0 commit comments

Comments
 (0)