Skip to content

Commit 8d088c0

Browse files
committed
refactor(SaveDatasetModal): improve layout by making fields static and adjusting scroll behavior
1 parent 9965e96 commit 8d088c0

1 file changed

Lines changed: 29 additions & 19 deletions

File tree

DashAI/front/src/components/notebooks/datasetCreation/SaveDatasetModal.jsx

Lines changed: 29 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -239,15 +239,15 @@ export function SaveDatasetModal({
239239
</IconButton>
240240
</Box>
241241

242-
{/* Scrollable Content */}
242+
{/* Static fields — always visible, never scroll */}
243243
<Box
244244
sx={{
245-
p: 3,
245+
px: 3,
246+
pt: 3,
246247
display: "flex",
247248
flexDirection: "column",
248249
gap: 3,
249-
overflowY: "auto",
250-
flex: 1,
250+
flexShrink: 0,
251251
}}
252252
data-tour="save-dataset-modal-notebook"
253253
>
@@ -278,22 +278,32 @@ export function SaveDatasetModal({
278278
</Box>
279279
</FormSchemaFieldCard>
280280

281-
<Box>
282-
<Typography variant="subtitle2" gutterBottom>
283-
{t("datasets:label.appliedTransformations")}
281+
<Typography variant="subtitle2">
282+
{t("datasets:label.appliedTransformations")}
283+
</Typography>
284+
</Box>
285+
286+
{/* Scrollable converter list */}
287+
<Box
288+
sx={{
289+
px: 3,
290+
pb: 2,
291+
overflowY: "auto",
292+
flex: 1,
293+
minHeight: 0,
294+
}}
295+
>
296+
{localConverters.length === 0 ? (
297+
<Typography variant="body2" color="text.secondary">
298+
{t("datasets:label.noTransformationsApplied")}
284299
</Typography>
285-
{localConverters.length === 0 ? (
286-
<Typography variant="body2" color="text.secondary">
287-
{t("datasets:label.noTransformationsApplied")}
288-
</Typography>
289-
) : (
290-
<ConverterHistoryList
291-
converters={localConverters}
292-
onConverterDelete={handleConverterDeleteClick}
293-
showDeleteButtons={true}
294-
/>
295-
)}
296-
</Box>
300+
) : (
301+
<ConverterHistoryList
302+
converters={localConverters}
303+
onConverterDelete={handleConverterDeleteClick}
304+
showDeleteButtons={true}
305+
/>
306+
)}
297307
</Box>
298308

299309
{/* Footer - always visible */}

0 commit comments

Comments
 (0)