fixed magic numbers

Author: DashProsh

app/build.gradle.kts

@@ -24,14 +24,14 @@ dependencies {
 
 tasks.test {
     useJUnitPlatform()
-    finalizedBy("jacocoTestReport") // Ссылаемся на задачу по имени, чтобы она выполнялась после тестов
+    finalizedBy("jacocoTestReport")
 }
 
 tasks.named<JacocoReport>("jacocoTestReport") {
-    dependsOn(tasks.test) // Задаем зависимость от задачи тестирования
+    dependsOn(tasks.test)
     reports {
-        xml.required.set(true)  // Генерация XML отчета
-        html.required.set(true) // Генерация HTML отчета
+        xml.required.set(true)
+        html.required.set(true)
     }
 }
 

app/src/main/java/hexlet/code/games/Calc.java

@@ -10,15 +10,18 @@
 public class Calc {
     public static int calc() {
 
+        final int maxRandomNumber1 = 19;
+        final int maxRandomNumber2 = 9;
+
         Random random = new Random();
         String mainGameQuestion = "What is the result of the expression?";
 
         String[] question = new String[Engine.ROUNDS];
         String[] correctAnswer = new String[Engine.ROUNDS];
 
         for (var i = 0; i < Engine.ROUNDS; i++) {
-            int randomNumber1 = random.nextInt(19) + 1;
-            int randomNumber2 = random.nextInt(9) + 1;
+            int randomNumber1 = random.nextInt(maxRandomNumber1) + 1;
+            int randomNumber2 = random.nextInt(maxRandomNumber2) + 1;
 
             String plus = randomNumber1 + " + " + randomNumber2;
             String minus = randomNumber1 + " - " + randomNumber2;

app/src/main/java/hexlet/code/games/Even.java

@@ -7,14 +7,16 @@
 public class Even {
     public static int even() {
 
+        final int maxRandomNumber = 5;
+
         Random random = new Random();
         String mainGameQuestion = "Answer 'yes' if the number is even, otherwise answer 'no'.";
 
         String[] question = new String[Engine.ROUNDS];
         String[] correctAnswer = new String[Engine.ROUNDS];
 
         for (var i = 0; i < Engine.ROUNDS; i++) {
-            int randomNumber = random.nextInt(99) + 1;
+            int randomNumber = random.nextInt(maxRandomNumber) + 1;
             question[i] = Integer.toString(randomNumber);
             correctAnswer[i] = (randomNumber % 2 == 0) ? "yes" : "no";
         }

app/src/main/java/hexlet/code/games/Gcd.java

@@ -8,6 +8,10 @@
 
 public class Gcd {
     public static int gcd() {
+
+        final int maxrandomCommon = 10;
+        final int maxRandomNumber = 10;
+
         Random random = new Random();
         String mainGameQuestion = "Find the greatest common divisor of given numbers.";
 
@@ -16,9 +20,9 @@ public static int gcd() {
 
         for (var i = 0; i < Engine.ROUNDS; i++) {
 
-            int randomCommon = random.nextInt(10) + 2;
-            int randomNumber1 = randomCommon * (random.nextInt(10) + 1);
-            int randomNumber2 = randomCommon * (random.nextInt(10) + 1);
+            int randomCommon = random.nextInt(maxrandomCommon) + 2;
+            int randomNumber1 = randomCommon * (random.nextInt(maxRandomNumber) + 1);
+            int randomNumber2 = randomCommon * (random.nextInt(maxRandomNumber) + 1);
 
             BigInteger bigA = BigInteger.valueOf(randomNumber1);
             BigInteger bigB = BigInteger.valueOf(randomNumber2);

app/src/main/java/hexlet/code/games/Prime.java

@@ -7,14 +7,16 @@
 public class Prime {
     public static int prime() {
 
+        final int maxRandomNumber = 20;
+
         Random random = new Random();
         String mainGameQuestion = "Answer 'yes' if given number is prime. Otherwise answer 'no'.";
 
         String[] question = new String[Engine.ROUNDS];
         String[] correctAnswer = new String[Engine.ROUNDS];
 
         for (var i = 0; i < Engine.ROUNDS; i++) {
-            int randomNumber = random.nextInt(20) + 2;
+            int randomNumber = random.nextInt(maxRandomNumber) + 2;
             question[i] = Integer.toString(randomNumber);
 
             boolean isPrime = true;

app/src/main/java/hexlet/code/games/Progression.java

@@ -7,6 +7,11 @@
 
 public class Progression {
     public static int progression() {
+
+        final int minArrayLength = 5;
+        final int maxStep = 9;
+        final int maxStartValue = 14;
+
         Random random = new Random();
         String mainGameQuestion = "What number is missing in the progression?";
 
@@ -15,11 +20,11 @@ public static int progression() {
 
         for (var i = 0; i < Engine.ROUNDS; i++) {
 
-            int arrayLength = random.nextInt(5) + 5;
+            int arrayLength = random.nextInt(minArrayLength) + minArrayLength;
             int[] array = new int[arrayLength];
 
-            int step = random.nextInt(9) + 1;
-            int start = random.nextInt(14) + 1;
+            int step = random.nextInt(maxStep) + 1;
+            int start = random.nextInt(maxStartValue) + 1;
 
             for (int j = 0; j < arrayLength; j++) {
                 array[j] = start + j * step;