Merge pull request #1 from Dashlane/fix-error-with-comments

Fix TypeError Exception when stylesheet uses CSS comments

Author: tregagnon

package.json

@@ -18,7 +18,7 @@
   },
   "homepage": "https://github.com/Dashlane/css-variables-loader#readme",
   "devDependencies": {
-    "ava": "^0.13.0"
+    "ava": "^0.16.0"
   },
   "dependencies": {
     "css": "^2.2.1"

src/index.js

@@ -5,7 +5,7 @@ module.exports = function(source) {
   css.parse(source).stylesheet.rules
     .filter(rule => rule.selectors.some(sel => sel === ':root'))
     .forEach(rule => rule.declarations
-      .filter(decl => decl.property.indexOf('--') === 0)
+      .filter(decl => decl.type === 'declaration' && decl.property.indexOf('--') === 0)
       .forEach(decl => result[decl.property] = decl.value));
   return 'module.exports = ' + JSON.stringify(result);
 };

test/simple.js

@@ -8,7 +8,7 @@ var check = function(name, css, result){
     test(name, function(t){
         var module = { exports: {} };
         eval(loader(css));
-        t.same(module.exports, result);
+        t.deepEqual(module.exports, result);
     });
 };
 
@@ -30,3 +30,6 @@ check('should only import from :root',
 check('should import from :root among multiple selectors',
     ':hover, :root { --theme: red }',
     { '--theme': 'red' })
+check('should not break when there is a comment',
+  ':root { --theme: red; /* important info */ --accent: blue }',
+  { '--accent': 'blue', '--theme': 'red' })