Skip to content

Dashlane extension patches PublicKeyCredential[Symbol.hasInstance] with an non-configurable property #4

@IgorMinar

Description

@IgorMinar

I'm a web-fragments.dev maintainer and got a report that the Dashlane extension was breaking applications that used web-fragments.

Upon further investigation I realized that the Dashlane extension was monkey-patching the PublicKeyCredential[Symbol.hasInstance] with a property that was non-configurable:

{value: Proxy(Function), writable: false, enumerable: false, configurable: false}

Monkey patching a property that is normally undefined or configurable with a descriptor that is non-configurable is unexpected, and results in composability issues. Can you please change your patch to make the property descriptor configurable to avoid these issues?

Thank you for considering.

Related PR: web-fragments/web-fragments#246

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions