adjust for test environments

Author: Dashron

.github/workflows/nodejs.yml

@@ -4,25 +4,26 @@ on: [push, pull_request]
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
         # 8.x and lower not supported due to lack of URL object
         # 10.x not supported with the current version of EJS. If you need it, it will probably run fine
-        node-version: [14.x, 16.x, 18.x, 19.x]
+        # 14.x and 15.x are not supported by vitest
+        # 19.x and up the request UA is `undici` and affected the tests
+        node-version: [18.x, 19.x, 20.x, 21.x, 22.x]
 
     steps:
-    - uses: actions/checkout@v1
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - name: npm install, build, and test
-      run: |
-        npm install
-        npm run build --if-present
-        npm test
-      env:
-        CI: true
+      - uses: actions/checkout@v1
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: npm install, build, and test
+        run: |
+          npm install
+          npm run build --if-present
+          npm test
+        env:
+          CI: true

test/__tests__/client/request.test.ts

@@ -39,14 +39,18 @@ describe('request', () => {
 				one : 'two'
 			}).then(function (response: Response) {
 				expect(response.status).toEqual(200);
-				expect(JSON.parse(response.body as string)).toEqual({
+
+				const body = JSON.parse(response.body as string);
+				// as of node 19 this became uncidi, I don't want to reject old versions for just this one test issue
+				delete body.headers['user-agent'];
+
+				expect(body).toEqual({
 					url: '/',
 					method: 'GET',
 					body: '',
 					headers: {
 						one: 'two',
 						accept: '*/*',
-						'user-agent': 'node',
 						'accept-encoding': 'gzip, deflate',
 						'accept-language': '*',
 						'sec-fetch-mode': 'cors',
@@ -69,15 +73,19 @@ describe('request', () => {
 				one : ['two', 'three']
 			}).then(function (response: Response) {
 				expect(response.status).toEqual(200);
-				expect(JSON.parse(response.body as string)).toEqual({
+
+				const body = JSON.parse(response.body as string);
+				// as of node 19 this became uncidi, I don't want to reject old versions for just this one test issue
+				delete body.headers['user-agent'];
+
+				expect(body).toEqual({
 					url: '/',
 					method: 'GET',
 					body: '',
 					headers: {
 						// node fetch doesn't seem to retain dupe arrays, this is what we get.
 						one: 'two, three',
 						accept: '*/*',
-						'user-agent': 'node',
 						'accept-encoding': 'gzip, deflate',
 						'accept-language': '*',
 						connection: 'keep-alive',
@@ -107,7 +115,10 @@ describe('request', () => {
 			}).then(function (response: Response) {
 				expect(response.status).toEqual(200);
 
-				expect(JSON.parse(response.body as string)).toMatchObject({
+				const body = JSON.parse(response.body as string);
+				// as of node 19 this became uncidi, I don't want to reject old versions for just this one test issue
+				delete body.headers['user-agent'];
+				expect(body).toMatchObject({
 					url: '/',
 					method: 'POST',
 					body: '{"yeah": "what"}',
@@ -116,7 +127,6 @@ describe('request', () => {
 						'content-type': 'text/plain;charset=UTF-8',
 						accept: '*/*',
 						'content-length': '16',
-						'user-agent': 'node',
 						'accept-encoding': 'gzip, deflate',
 						connection: 'keep-alive',
 						host: `127.0.0.1:${port}`,