From 905095fc4c9aabcc1bd764808a6526742dba3529 Mon Sep 17 00:00:00 2001 From: James Smith Date: Tue, 7 Jan 2025 14:38:27 +0000 Subject: [PATCH 1/3] test and support Ruby 3.4 --- .github/workflows/push.yml | 4 ++-- .ruby-version | 2 +- README.md | 2 +- csvlint.gemspec | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index b7e9a7f..77720f2 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3'] + ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3', '3.4'] activesupport-version: - activesupport_5.2 - activesupport_6.0 @@ -58,7 +58,7 @@ jobs: - uses: ruby/setup-ruby@v1 with: bundler-cache: true - ruby-version: "3.3" + ruby-version: "3.4" - name: Install dependencies run: bundle install - name: Run the tests diff --git a/.ruby-version b/.ruby-version index 15a2799..47b322c 100644 --- a/.ruby-version +++ b/.ruby-version @@ -1 +1 @@ -3.3.0 +3.4.1 diff --git a/README.md b/README.md index ecd3fb1..7778860 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ A ruby gem to support validating CSV files to check their syntax and contents. Y ## Development -`ruby version 3.3` +`ruby version 3.4` ### Tests diff --git a/csvlint.gemspec b/csvlint.gemspec index d20f5b0..8ef6139 100644 --- a/csvlint.gemspec +++ b/csvlint.gemspec @@ -16,7 +16,7 @@ Gem::Specification.new do |spec| spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.required_ruby_version = [">= 2.5", "< 3.4"] + spec.required_ruby_version = [">= 2.5", "< 3.5"] spec.add_dependency "csv" spec.add_dependency "rainbow" From b8016b0b6358acbc5136735534cad2e41d7055e3 Mon Sep 17 00:00:00 2001 From: James Smith Date: Tue, 14 Jan 2025 15:57:42 +0000 Subject: [PATCH 2/3] remove henry and use coveralls_reborn --- csvlint.gemspec | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/csvlint.gemspec b/csvlint.gemspec index 8ef6139..56495f9 100644 --- a/csvlint.gemspec +++ b/csvlint.gemspec @@ -40,13 +40,12 @@ Gem::Specification.new do |spec| spec.add_development_dependency "rspec" spec.add_development_dependency "rspec-pride" spec.add_development_dependency "rspec-expectations" - spec.add_development_dependency "coveralls" + spec.add_development_dependency "coveralls_reborn" spec.add_development_dependency "byebug" spec.add_development_dependency "github_changelog_generator" spec.add_development_dependency "aruba" spec.add_development_dependency "rdf", "< 4.0" spec.add_development_dependency "rdf-turtle" - spec.add_development_dependency "henry" spec.add_development_dependency "standardrb" spec.add_development_dependency "appraisal" end From 9ce6cc3aa778467e7eca979c43262f4a745295d3 Mon Sep 17 00:00:00 2001 From: James Smith Date: Tue, 14 Jan 2025 16:06:21 +0000 Subject: [PATCH 3/3] add mutex_m dependency explicitly for ruby 3.4 and activesupport < 7.1 --- csvlint.gemspec | 1 + 1 file changed, 1 insertion(+) diff --git a/csvlint.gemspec b/csvlint.gemspec index 56495f9..56e2321 100644 --- a/csvlint.gemspec +++ b/csvlint.gemspec @@ -29,6 +29,7 @@ Gem::Specification.new do |spec| spec.add_dependency "thor" spec.add_dependency "rack" spec.add_dependency "net-http-persistent" + spec.add_dependency "mutex_m" # For Ruby 3.4+ spec.add_development_dependency "bundler", ">= 1.3" spec.add_development_dependency "rake"