fixup! Make mirror_file fail if file object already exists (#7134)

Author: nadove-ucsc

test/indexer/test_mirror_controller.py

@@ -96,15 +96,16 @@ def test_mirroring(self):
                 with self.subTest('mirror_partition'):
                     file, file_message = self._test_mirror_partition(partition_message)
 
-                    with self.subTest('mirror_file', corrupted=False):
+                    with self.subTest('mirror_file', corrupted=False, exists=False):
                         self._test_mirror_file(file, file_message)
                         self._s3.delete_object(Bucket=self.bucket,
                                                Key=self.mirror_controller.service.info_object_key(file))
+                        with self.subTest('mirror_file', corrupted=False, exists=True):
+                            self._test_reuploaded_file(file_message)
 
                     with self.subTest('mirror_file', corrupted=True):
                         self._test_corrupted_download(file_message)
 
-
     _file_contents = b'lorem ipsum dolor sit\n'
 
     @property
@@ -172,6 +173,14 @@ def _test_corrupted_download(self, file_message):
                 self.mirror_controller.mirror(event)
             self.assertTrue(R.caused(e.exception))
 
+    def _test_reuploaded_file(self, file_message):
+        event = [self._mock_sqs_record(file_message)]
+        with patch.object(MirrorService, '_download', return_value=self._file_contents):
+            with self.assertRaises(AssertionError) as e:
+                self.mirror_controller.mirror(event)
+        self.assertTrue(R.caused(e.exception))
+        self.assertEqual(e.exception.args[0].args[0], 'Object exists')
+
     def test_info_schema(self):
         client = http_client(log)
         file = MagicMock(content_type='text/plain')