Skip to content

Commit de14d18

Browse files
committed
fixup! [2/2] [a] Fix: Can't use curl to download a single manifest in one invocation (#5918)
1 parent 5b02cc0 commit de14d18

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

lambdas/service/app.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -739,9 +739,9 @@ def validate_json_param(name: str, value: str) -> MutableJSON:
739739
raise BRE(f'The {name!r} parameter is not valid JSON')
740740

741741

742-
def validate_wait(wait: str):
742+
def validate_wait(wait: str | None):
743743
valid_values = ['0', '1']
744-
if wait not in valid_values:
744+
if wait not in [None, *valid_values]:
745745
raise BRE(f'Invalid wait value `{wait}`. Must be one of {valid_values}')
746746

747747

@@ -1709,8 +1709,6 @@ def _file_manifest(fetch: bool, token_or_key: Optional[str] = None):
17091709
default_format = app.metadata_plugin.manifest_formats[0].value
17101710
query_params.setdefault('format', default_format)
17111711
else:
1712-
if not fetch:
1713-
query_params.setdefault('wait', '0')
17141712
validate_params(query_params,
17151713
# If the initial request was a POST to the non-fetch
17161714
# endpoint, the 'wait' param will be carried over to

src/azul/service/manifest_controller.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
from collections.abc import (
22
Mapping,
33
)
4+
from math import (
5+
ceil,
6+
)
47
from typing import (
58
Optional,
69
TypedDict,
@@ -234,8 +237,8 @@ def get_manifest_async(self,
234237
elif wait == '1':
235238
retry_after = body.get('Retry-After')
236239
if retry_after is not None:
237-
time_slept = self.server_side_sleep(retry_after)
238-
body['Retry-After'] = round(retry_after - time_slept)
240+
time_slept = self.server_side_sleep(float(retry_after))
241+
body['Retry-After'] = ceil(retry_after - time_slept)
239242
else:
240243
assert False, wait
241244

0 commit comments

Comments
 (0)