chore: drop unused superseded prop and SupersededTag styled (#949)

Audit while landing #949 revealed superseded was always passed as
false from every call site (filters.tsx, FilterTag/utils.ts,
stories args, filterTags.stories.tsx) and the SupersededTag
styled component was therefore never rendered.

Strips the prop from CategoryTag, FilterTag, FilterTags, and the
two stories files. Deletes filterTag.styles.ts (only contained
SupersededTag).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: frano-m

src/common/entities.ts

@@ -40,7 +40,6 @@ export type ClearAll = typeof CLEAR_ALL;
 export interface CategoryTag {
   label: string;
   onRemove: () => void;
-  superseded: boolean;
 }
 
 /**

src/components/Filter/components/FilterTag/filterTag.styles.ts

@@ -1,13 +1,11 @@
 import { CloseRounded } from "@mui/icons-material";
 import { Chip, Tooltip } from "@mui/material";
 import { JSX } from "react";
-import { SupersededTag } from "./filterTag.styles";
 import { useTooltipTitle } from "./hooks/UseTooltipTitle/hook";
 
 export interface FilterTagProps {
   label: string;
   onRemove: () => void;
-  superseded: boolean;
 }
 
 const DEFAULT_SLOT_PROPS = {
@@ -27,12 +25,7 @@ const DEFAULT_SLOT_PROPS = {
   },
 };
 
-export const FilterTag = ({
-  label,
-  onRemove,
-  superseded,
-}: FilterTagProps): JSX.Element => {
-  const Tag = superseded ? SupersededTag : Chip;
+export const FilterTag = ({ label, onRemove }: FilterTagProps): JSX.Element => {
   const { ref, title } = useTooltipTitle(label);
 
   return (
@@ -42,7 +35,7 @@ export const FilterTag = ({
       slotProps={DEFAULT_SLOT_PROPS}
       title={title}
     >
-      <Tag
+      <Chip
         clickable={false} // removes unwanted active and hover ui; "pointer" cursor added to "filterTag" variant in theme.
         color="primary"
         deleteIcon={<CloseRounded color="inherit" />}

src/components/Filter/components/FilterTag/filterTag.tsx

@@ -6,17 +6,14 @@ import { FilterTag } from "../filterTag";
 export const DEFAULT_ARGS: ComponentProps<typeof FilterTag> = {
   label: "male",
   onRemove: fn(),
-  superseded: false,
 };
 
 export const WITH_ELLIPSIS_ARGS: ComponentProps<typeof FilterTag> = {
   label: LOREM_IPSUM.LONG,
   onRemove: fn(),
-  superseded: false,
 };
 
 export const WITH_RANGE_ARGS: ComponentProps<typeof FilterTag> = {
   label: "10 - 34",
   onRemove: fn(),
-  superseded: false,
 };

src/components/Filter/components/FilterTag/stories/args.ts

@@ -28,7 +28,6 @@ export function buildRangeTag(
           undefined,
           VIEW_KIND.RANGE,
         ),
-      superseded: false,
     },
   ];
 }

src/components/Filter/components/FilterTag/utils.ts

@@ -31,32 +31,26 @@ export const FilterTagsStory: Story = {
       {
         label: "Normal",
         onRemove: onRemove,
-        superseded: false,
       },
       {
         label: "abscess",
         onRemove: onRemove,
-        superseded: true,
       },
       {
         label: "acoustic neuroma",
         onRemove: onRemove,
-        superseded: false,
       },
       {
         label: "acute kidney failure",
         onRemove: onRemove,
-        superseded: false,
       },
       {
         label: "acute kidney tubular necrosis",
         onRemove: onRemove,
-        superseded: false,
       },
       {
         label: "alcohol abuse",
         onRemove: onRemove,
-        superseded: false,
       },
     ],
   },

src/components/Filter/components/FilterTags/filterTags.stories.tsx

@@ -10,13 +10,8 @@ export interface FilterTagsProps {
 export const FilterTags = ({ tags }: FilterTagsProps): JSX.Element | null => {
   return tags && tags.length ? (
     <Tags>
-      {tags.map(({ label, onRemove, superseded }, t) => (
-        <Tag
-          key={`${label}${t}`}
-          label={label}
-          onRemove={onRemove}
-          superseded={superseded}
-        />
+      {tags.map(({ label, onRemove }, t) => (
+        <Tag key={`${label}${t}`} label={label} onRemove={onRemove} />
       ))}
     </Tags>
   ) : null;

src/components/Filter/components/FilterTags/filterTags.tsx

@@ -52,7 +52,6 @@ function buildFilterTags(
       return {
         label: label,
         onRemove: () => onFilter(categoryKey, categoryValueKey, !selected),
-        superseded: false,
       };
     });
 }