[CORE-514] Delete compact data tables setting and feature flag (#5445)

Author: samanehsan

src/libs/ajax/workspaces/workspace-models.ts

@@ -37,7 +37,6 @@ export type WorkspaceSetting =
   | SoftDeleteSetting
   | RequesterPaysSetting
   | SeparateSubmissionFinalOutputsSetting
-  | ImprovedDataTablesSetting
   | WorkspaceAnalysisLogRetentionSetting;
 
 export interface BucketLifecycleSetting {
@@ -55,11 +54,6 @@ export interface RequesterPaysSetting {
   config: { enabled: boolean };
 }
 
-export interface ImprovedDataTablesSetting {
-  settingType: 'CompactDataTables';
-  config: { enabled: boolean };
-}
-
 export interface WorkspaceAnalysisLogRetentionSetting {
   settingType: 'GcpLogBucketRetention';
   config: { retentionDurationInDays: number };

src/libs/events.ts

@@ -198,7 +198,6 @@ const eventsList = {
   workspaceSettingsBucketLifecycle: 'workspace:settings:bucketLifecycle',
   workspaceSettingsSoftDelete: 'workspace:settings:softDelete',
   workspaceSettingsRequesterPays: 'workspace:settings:requesterPays',
-  workspaceSettingsImprovedDataTables: 'workspace:settings:improvedDataTables',
   workspaceSettingsLogRetention: 'workspace:settings:logRetention',
   workspaceSettingsMenuTab: 'workspace:settings:menuTab',
   workspaceShare: 'workspace:share',

src/libs/feature-previews-config.ts

@@ -2,7 +2,6 @@ export const JUPYTERLAB_GCP_FEATURE_ID = 'jupyterlab-gcp';
 export const ENABLE_JUPYTERLAB_ID = 'enableJupyterLabGCP';
 export const COHORT_BUILDER_CARD = 'cohortBuilderCard';
 export const RAS_PROVIDER = 'rasProvider';
-export const IMPROVED_DATA_TABLES = 'improvedDataTables';
 export const WORKFLOW_RETRY_WITH_MORE_MEMORY = 'retryWithMoreMemory';
 
 // If the groups option is defined for a FeaturePreview, it must contain at least one group.
@@ -75,16 +74,6 @@ const featurePreviewsConfig: readonly FeaturePreview[] = [
     feedbackUrl: 'https://support.terra.bio/hc/en-us/articles/32634034451099',
     lastUpdated: '6/26/2025',
   },
-  {
-    id: IMPROVED_DATA_TABLES,
-    title: 'Improved Data Table Performance',
-    description: 'Opt-in to enable a workspace setting that will migrate your data tables for improved performance.',
-    groups: ['preview-improved-data-tables'],
-    feedbackUrl: `mailto:[email protected]?subject=${encodeURIComponent(
-      'Support for Improved Data Table Performance'
-    )}`,
-    lastUpdated: '7/10/2025',
-  },
   {
     id: WORKFLOW_RETRY_WITH_MORE_MEMORY,
     title: 'Retry Workflow Tasks with More Memory',

src/workspaces/SettingsModal/ImprovedDataTables.tsx

@@ -6,13 +6,11 @@ import React from 'react';
 import { Metrics, MetricsContract } from 'src/libs/ajax/Metrics';
 import { SamResources, SamResourcesContract } from 'src/libs/ajax/SamResources';
 import {
-  ImprovedDataTablesSetting,
   SeparateSubmissionFinalOutputsSetting,
   WorkspaceAnalysisLogRetentionSetting,
 } from 'src/libs/ajax/workspaces/workspace-models';
 import { Workspaces, WorkspacesAjaxContract, WorkspaceV2Contract } from 'src/libs/ajax/workspaces/Workspaces';
 import Events, { extractWorkspaceDetails } from 'src/libs/events';
-import { isFeaturePreviewEnabled } from 'src/libs/feature-previews';
 import { asMockedFn, partial, renderWithAppContexts as render, SelectHelper } from 'src/testing/test-utils';
 import { defaultGoogleWorkspace, makeGoogleWorkspace } from 'src/testing/workspace-fixtures';
 import SettingsModal from 'src/workspaces/SettingsModal/SettingsModal';
@@ -133,16 +131,6 @@ describe('SettingsModal', () => {
     config: { enabled: false },
   };
 
-  const improvedDataTablesEnabledSetting: ImprovedDataTablesSetting = {
-    settingType: 'CompactDataTables',
-    config: { enabled: true },
-  };
-
-  const improvedDataTablesDisabledSetting: ImprovedDataTablesSetting = {
-    settingType: 'CompactDataTables',
-    config: { enabled: false },
-  };
-
   const separateSubmissionOutputsDisabledSetting: SeparateSubmissionFinalOutputsSetting = {
     settingType: 'SeparateSubmissionFinalOutputs',
     config: { enabled: false },
@@ -189,10 +177,6 @@ describe('SettingsModal', () => {
     asMockedFn(isWorkspaceOwner).mockReturnValue(false);
   };
 
-  const enableFeaturePreview = () => {
-    asMockedFn(isFeaturePreviewEnabled).mockReturnValue(true); // Mock IMPROVED_DATA_TABLES as enabled
-  };
-
   it('has no accessibility errors', async () => {
     // Arrange
     setup([twoRules], jest.fn());
@@ -926,129 +910,6 @@ describe('SettingsModal', () => {
     });
   });
 
-  describe('Improved DataTables Settings', () => {
-    const getImprovedDataTablesToggle = () => screen.getByLabelText('Improved Data Tables:');
-
-    it('renders the option as disabled if the user is not an owner', async () => {
-      // Arrange
-      setup([], jest.fn());
-      mockNotOwner();
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={makeGoogleWorkspace({ accessLevel: 'READER' })} onDismiss={jest.fn()} />);
-      });
-
-      // Assert
-      expect(getImprovedDataTablesToggle()).toBeDisabled();
-    });
-
-    it('renders the option as off if no settings exist', async () => {
-      // Arrange
-      setup([], jest.fn());
-      mockNotOwner();
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={defaultGoogleWorkspace} onDismiss={jest.fn()} />);
-      });
-
-      // Assert
-      expect(getImprovedDataTablesToggle()).not.toBeChecked();
-    });
-
-    it('renders the option as off if improved data tables is disabled', async () => {
-      // Arrange
-      setup([improvedDataTablesDisabledSetting], jest.fn());
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={defaultGoogleWorkspace} onDismiss={jest.fn()} />);
-      });
-
-      // Assert
-      expect(getImprovedDataTablesToggle()).not.toBeChecked();
-    });
-
-    it('renders the option as on but disabled if improved data tables is enabled', async () => {
-      // Arrange
-      setup([improvedDataTablesEnabledSetting], jest.fn());
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={defaultGoogleWorkspace} onDismiss={jest.fn()} />);
-      });
-
-      // Assert
-      expect(getImprovedDataTablesToggle()).toBeChecked();
-      expect(getImprovedDataTablesToggle()).toBeDisabled();
-    });
-
-    it('does not support disabling improved data tables', async () => {
-      // Arrange
-      const updateSettingsMock = jest.fn();
-      setup([improvedDataTablesEnabledSetting], updateSettingsMock);
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={defaultGoogleWorkspace} onDismiss={jest.fn()} />);
-      });
-
-      const toggle = getImprovedDataTablesToggle();
-      expect(toggle).toBeDisabled();
-    });
-
-    it('supports enabling improved data tables', async () => {
-      // Arrange
-      const user = userEvent.setup();
-      const updateSettingsMock = jest.fn();
-      setup([], updateSettingsMock);
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={defaultGoogleWorkspace} onDismiss={jest.fn()} />);
-      });
-
-      const toggle = getImprovedDataTablesToggle();
-      expect(toggle).not.toBeChecked();
-      await user.click(toggle);
-      expect(toggle).toBeChecked();
-
-      await user.click(screen.getByRole('button', { name: 'Save' }));
-
-      // Assert
-      expect(updateSettingsMock).toHaveBeenCalledWith([improvedDataTablesEnabledSetting, defaultSoftDeleteSetting]);
-      expect(captureEvent).toHaveBeenCalledWith(Events.workspaceSettingsImprovedDataTables, {
-        enabled: true,
-        ...extractWorkspaceDetails(defaultGoogleWorkspace),
-      });
-    });
-
-    it('does not event if improved data tables did not change', async () => {
-      // Arrange
-      const updateSettingsMock = jest.fn();
-      setup([improvedDataTablesEnabledSetting], updateSettingsMock);
-      enableFeaturePreview();
-
-      // Act
-      await act(async () => {
-        render(<SettingsModal workspace={defaultGoogleWorkspace} onDismiss={jest.fn()} />);
-      });
-      const toggle = getImprovedDataTablesToggle();
-      expect(toggle).toBeDisabled();
-
-      // Assert
-      expect(updateSettingsMock).not.toHaveBeenCalledWith([improvedDataTablesEnabledSetting, defaultSoftDeleteSetting]);
-      expect(captureEvent).not.toHaveBeenCalledWith();
-    });
-  });
-
   describe('Workspace Analysis Log Retention Settings', () => {
     const getRetentionDaysElement = () => screen.getAllByLabelText('Days to retain:')[1];
 

src/workspaces/SettingsModal/SettingsModal.test.tsx

@@ -3,34 +3,26 @@ import _ from 'lodash/fp';
 import React, { ReactNode, useEffect, useState } from 'react';
 import { Metrics } from 'src/libs/ajax/Metrics';
 import { SamResources } from 'src/libs/ajax/SamResources';
-import {
-  ImprovedDataTablesSetting,
-  WorkspaceAnalysisLogRetentionSetting,
-} from 'src/libs/ajax/workspaces/workspace-models';
+import { WorkspaceAnalysisLogRetentionSetting } from 'src/libs/ajax/workspaces/workspace-models';
 import { Workspaces } from 'src/libs/ajax/workspaces/Workspaces';
 import colors from 'src/libs/colors';
 import { withErrorReporting } from 'src/libs/error';
 import Events, { extractWorkspaceDetails } from 'src/libs/events';
-import { isFeaturePreviewEnabled } from 'src/libs/feature-previews';
-import { IMPROVED_DATA_TABLES } from 'src/libs/feature-previews-config';
 import { useCancellation } from 'src/libs/react-utils';
 import * as Utils from 'src/libs/utils';
 import BucketLifecycleSettings from 'src/workspaces/SettingsModal/BucketLifecycleSettings';
-import ImprovedDataTables from 'src/workspaces/SettingsModal/ImprovedDataTables';
 import RequesterPays from 'src/workspaces/SettingsModal/RequesterPays';
 import SoftDelete from 'src/workspaces/SettingsModal/SoftDelete';
 import {
   BucketLifecycleSetting,
   DeleteBucketLifecycleRule,
   isBucketLifecycleSetting,
   isDeleteBucketLifecycleRule,
-  isImprovedDataTablesSetting,
   isLogRetentionSetting,
   isRequesterPaysSetting,
   isSoftDeleteSetting,
   modifyFirstBucketDeletionRule,
   modifyFirstSoftDeleteSetting,
-  modifyImprovedDataTablesSetting,
   modifyLogRetentionSetting,
   modifyRequesterPaysSetting,
   removeFirstBucketDeletionRule,
@@ -65,9 +57,6 @@ const SettingsModal = (props: SettingsModalProps): ReactNode => {
 
   const [requesterPaysEnabled, setRequesterPaysEnabled] = useState(false);
 
-  const [originalImprovedDataTablesSetting, setOriginalImprovedDataTablesSetting] = useState(false);
-  const [improvedDataTablesEnabled, setImprovedDataTablesEnabled] = useState(false);
-
   // initial is null so that the input is empty when the modal opens
   const [logRetention, setLogRetention] = useState<number | null>(null);
 
@@ -149,12 +138,6 @@ const SettingsModal = (props: SettingsModalProps): ReactNode => {
     return settings.find((setting: WorkspaceSetting) => isRequesterPaysSetting(setting)) as RequesterPaysSetting;
   };
 
-  const getImproveDataTableSetting = (settings: WorkspaceSetting[]): ImprovedDataTablesSetting | undefined => {
-    return settings.find((setting: WorkspaceSetting) =>
-      isImprovedDataTablesSetting(setting)
-    ) as ImprovedDataTablesSetting;
-  };
-
   const getLogRetentionSetting = (settings: WorkspaceSetting[]): WorkspaceAnalysisLogRetentionSetting | undefined => {
     return settings.find((setting: WorkspaceSetting) =>
       isLogRetentionSetting(setting)
@@ -198,11 +181,6 @@ const SettingsModal = (props: SettingsModalProps): ReactNode => {
       const requesterPaysEnabled = requesterPays === undefined ? false : requesterPays.config.enabled;
       setRequesterPaysEnabled(requesterPaysEnabled);
 
-      const improvedDataTables = getImproveDataTableSetting(settings);
-      const improvedDataTablesEnabled = improvedDataTables ? improvedDataTables.config.enabled : false;
-      setOriginalImprovedDataTablesSetting(improvedDataTablesEnabled);
-      setImprovedDataTablesEnabled(improvedDataTablesEnabled);
-
       // if GcpLogBucketRetention setting doesn't exist, default to 30 days
       const logRetentionSetting = getLogRetentionSetting(settings);
       const logRetentionDays = logRetentionSetting ? logRetentionSetting.config.retentionDurationInDays : 30;
@@ -230,9 +208,6 @@ const SettingsModal = (props: SettingsModalProps): ReactNode => {
     const logRetentionInDays = logRetention ? logRetention! : 30; // default to 30 days if null
     newSettings = modifyLogRetentionSetting(newSettings, logRetentionInDays);
 
-    if (isFeaturePreviewEnabled(IMPROVED_DATA_TABLES) && improvedDataTablesEnabled) {
-      newSettings = modifyImprovedDataTablesSetting(newSettings, improvedDataTablesEnabled);
-    }
     await Workspaces().workspaceV2(namespace, name).updateSettings(newSettings);
 
     props.onDismiss();
@@ -297,19 +272,6 @@ const SettingsModal = (props: SettingsModalProps): ReactNode => {
       });
     }
 
-    // Event about improved data tables setting only if something actually changed.
-    const originalImprovedDataTablesSetting = getImproveDataTableSetting(workspaceSettings || []);
-    const newImprovedDataTablesSetting = getImproveDataTableSetting(newSettings);
-    if (originalImprovedDataTablesSetting === undefined && !newImprovedDataTablesSetting?.config.enabled) {
-      // If the workspace had no improved data tables setting before, and the current one is disabled, don't event.
-    } else if (!_.isEqual(originalImprovedDataTablesSetting, newImprovedDataTablesSetting)) {
-      // Event if the setting changed.
-      void Metrics().captureEvent(Events.workspaceSettingsImprovedDataTables, {
-        enabled: improvedDataTablesEnabled,
-        ...extractWorkspaceDetails(props.workspace),
-      });
-    }
-
     // Event about log bucket retention setting only if something actually changed
     const originalLogRetentionSetting = getLogRetentionSetting(workspaceSettings || []);
     const newLogRetentionSetting = getLogRetentionSetting(newSettings);
@@ -377,14 +339,6 @@ const SettingsModal = (props: SettingsModalProps): ReactNode => {
           isOwner={isOwner}
         />
       </div>
-      {isFeaturePreviewEnabled(IMPROVED_DATA_TABLES) && (
-        <ImprovedDataTables
-          originalImprovedDataTablesEnabled={originalImprovedDataTablesSetting}
-          improvedDataTablesEnabled={improvedDataTablesEnabled}
-          setImprovedDataTablesEnabled={setImprovedDataTablesEnabled}
-          isOwner={isOwner}
-        />
-      )}
       <div style={{ paddingBottom: '1.0rem', borderBottom: `1px solid ${colors.accent()}` }}>
         <WorkspaceAnalysisLogRetention
           retentionPeriodInDays={logRetention}